Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8306640: Open source several AWT TextArea related tests #1368

Closed

Conversation

Rudometov
Copy link
Member

@Rudometov Rudometov commented May 18, 2023

Clean backport, new tests, low risk
Checked on macOS x64, linux x64, windows x64: tests pass


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8306640: Open source several AWT TextArea related tests

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1368/head:pull/1368
$ git checkout pull/1368

Update a local copy of the PR:
$ git checkout pull/1368
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1368/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1368

View PR using the GUI difftool:
$ git pr show -t 1368

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1368.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 18, 2023

👋 Welcome back vrudomet! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 169a7c27a7c6521fbfb1e61fbe85e6d7b0470619 8306640: Open source several AWT TextArea related tests May 18, 2023
@openjdk
Copy link

openjdk bot commented May 18, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 18, 2023

@Rudometov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306640: Open source several AWT TextArea related tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • 2dc22d6: 8307134: Add GTS root CAs
  • 17b3640: 8268582: javadoc throws NPE with --ignore-source-errors option
  • 39a6b55: 8287854: Dangling reference in ClassVerifier::verify_class
  • 9cb0120: 8275233: Incorrect line number reported in exception stack trace thrown from a lambda expression
  • 32fda32: 8296343: CPVE thrown on missing content-length in OCSP response
  • 6b362e4: 8261495: Shenandoah: reconsider update references memory ordering
  • 879f4c5: 8297154: Improve safepoint cleanup logging
  • 2913a8d: 8306753: Open source several container AWT tests
  • 406d6ba: 8307378: Allow collectors to provide specific values for GC notifications' actions
  • 36c364d: 8284331: Add sanity check for signal handler modification warning.
  • ... and 2 more: https://git.openjdk.org/jdk17u-dev/compare/6cc377db3ed16f37df2ec6bd85f9586e4090feb3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 18, 2023
@mlbridge
Copy link

mlbridge bot commented May 18, 2023

Webrevs

@Rudometov
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 23, 2023
@openjdk
Copy link

openjdk bot commented May 23, 2023

@Rudometov
Your change (at version 47da1cc) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

Push approval is here.

/sponsor

@openjdk
Copy link

openjdk bot commented May 24, 2023

Going to push as commit 6033871.
Since your change was applied there have been 27 commits pushed to the master branch:

  • 05b2ff4: 8308554: [17u] Fix commit of 8286191. vm.musl was not removed from ExternalEditorTest
  • 9c0afc5: 8306752: Open source several container and component AWT tests
  • 4caa421: 8306755: Open source few Swing JComponent and AbstractButton tests
  • b5d3772: 8306683: Open source several clipboard and color AWT tests
  • 09e6880: 8306652: Open source AWT MenuItem related tests
  • 18ec008: 8306409: Open source AWT KeyBoardFocusManger, LightWeightComponent related tests
  • 536e133: 8306850: Open source AWT Modal related tests
  • 7277a75: 8306072: Open source several AWT MouseInfo related tests
  • 40526a7: 8307080: Open source some more JComboBox jtreg tests
  • e0f5fcd: 8306133: Open source few AWT Drag & Drop related tests
  • ... and 17 more: https://git.openjdk.org/jdk17u-dev/compare/6cc377db3ed16f37df2ec6bd85f9586e4090feb3...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 24, 2023
@openjdk openjdk bot closed this May 24, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 24, 2023
@openjdk
Copy link

openjdk bot commented May 24, 2023

@shipilev @Rudometov Pushed as commit 6033871.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants