Skip to content

Conversation

@navyxliu
Copy link
Member

@navyxliu navyxliu commented Jan 31, 2022

It reduces the risk that the launching JVMs are suppressed due to SIGQUIT sent by attaching clients(such as jcmd) on Posix systems. The patch applies cleanly to jdk17u. The risk is low because it only changes the signal handling of SIGQUIT at the early initialization phrase.

Testing: tier1. passed all-tiered tests of jdk.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8279124: VM does not handle SIGQUIT during initialization

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/137/head:pull/137
$ git checkout pull/137

Update a local copy of the PR:
$ git checkout pull/137
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/137/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 137

View PR using the GUI difftool:
$ git pr show -t 137

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/137.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 31, 2022

👋 Welcome back xliu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9bf6ffa19f1ea9efcadb3396d921305c9ec0b1d1 8279124: VM does not handle SIGQUIT during initialization Jan 31, 2022
@openjdk
Copy link

openjdk bot commented Jan 31, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jan 31, 2022
@openjdk
Copy link

openjdk bot commented Jan 31, 2022

@navyxliu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279124: VM does not handle SIGQUIT during initialization

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • 45002c0: 8277497: Last column cell in the JTable row is read as empty cell
  • 592adc8: 8278604: SwingSet2 table demo does not have accessible description set for images
  • 952f9c7: 8275645: [JVMCI] avoid unaligned volatile reads on AArch64
  • 869bb36: 8280414: Memory leak in DefaultProxySelector
  • c581598: 8273381: Assert in PtrQueueBufferAllocatorTest.stress_free_list_allocator_vm
  • cb769c0: 8269616: serviceability/dcmd/framework/VMVersionTest.java fails with Address already in use error
  • ac8a550: 8280155: [PPC64, s390] frame size checks are not yet correct
  • 22a6279: 8279924: [PPC64, s390] implement frame::is_interpreted_frame_valid checks
  • 7a5a8ab: 8280526: x86_32 Math.sqrt performance regression with -XX:UseSSE={0,1}
  • d34650a: 8279076: C2: Bad AD file when matching SqrtF with UseSSE=0
  • ... and 1 more: https://git.openjdk.java.net/jdk17u-dev/compare/b23271bd6db99928801602ca2c8c473175093d8d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 31, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 31, 2022

Webrevs

@navyxliu
Copy link
Member Author

navyxliu commented Feb 1, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 1, 2022
@openjdk
Copy link

openjdk bot commented Feb 1, 2022

@navyxliu
Your change (at version 776670c) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 1, 2022

Going to push as commit c03b95d.
Since your change was applied there have been 11 commits pushed to the master branch:

  • 45002c0: 8277497: Last column cell in the JTable row is read as empty cell
  • 592adc8: 8278604: SwingSet2 table demo does not have accessible description set for images
  • 952f9c7: 8275645: [JVMCI] avoid unaligned volatile reads on AArch64
  • 869bb36: 8280414: Memory leak in DefaultProxySelector
  • c581598: 8273381: Assert in PtrQueueBufferAllocatorTest.stress_free_list_allocator_vm
  • cb769c0: 8269616: serviceability/dcmd/framework/VMVersionTest.java fails with Address already in use error
  • ac8a550: 8280155: [PPC64, s390] frame size checks are not yet correct
  • 22a6279: 8279924: [PPC64, s390] implement frame::is_interpreted_frame_valid checks
  • 7a5a8ab: 8280526: x86_32 Math.sqrt performance regression with -XX:UseSSE={0,1}
  • d34650a: 8279076: C2: Bad AD file when matching SqrtF with UseSSE=0
  • ... and 1 more: https://git.openjdk.java.net/jdk17u-dev/compare/b23271bd6db99928801602ca2c8c473175093d8d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 1, 2022
@openjdk openjdk bot closed this Feb 1, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 1, 2022
@openjdk
Copy link

openjdk bot commented Feb 1, 2022

@phohensee @navyxliu Pushed as commit c03b95d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants