-
Notifications
You must be signed in to change notification settings - Fork 231
8279124: VM does not handle SIGQUIT during initialization #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back xliu! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
|
@navyxliu This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 11 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
/integrate |
|
/sponsor |
|
Going to push as commit c03b95d.
Your commit was automatically rebased without conflicts. |
|
@phohensee @navyxliu Pushed as commit c03b95d. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
It reduces the risk that the launching JVMs are suppressed due to SIGQUIT sent by attaching clients(such as jcmd) on Posix systems. The patch applies cleanly to jdk17u. The risk is low because it only changes the signal handling of SIGQUIT at the early initialization phrase.
Testing: tier1. passed all-tiered tests of jdk.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/137/head:pull/137$ git checkout pull/137Update a local copy of the PR:
$ git checkout pull/137$ git pull https://git.openjdk.java.net/jdk17u-dev pull/137/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 137View PR using the GUI difftool:
$ git pr show -t 137Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/137.diff