Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8287854: Dangling reference in ClassVerifier::verify_class #1384

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented May 22, 2023

Clean backport to improve verifier reliability.

Additional testing:

  • Linux x86_64 fastdebug tier1 tier2 tier3

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8287854: Dangling reference in ClassVerifier::verify_class

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1384/head:pull/1384
$ git checkout pull/1384

Update a local copy of the PR:
$ git checkout pull/1384
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1384/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1384

View PR using the GUI difftool:
$ git pr show -t 1384

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1384.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 22, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3fa99844a69401f84677e7d512ffd937f7f16898 8287854: Dangling reference in ClassVerifier::verify_class May 22, 2023
@openjdk
Copy link

openjdk bot commented May 22, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 22, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8287854: Dangling reference in ClassVerifier::verify_class

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 36c364d: 8284331: Add sanity check for signal handler modification warning.
  • 4a0f0f4: 8276058: Some swing test fails on specific CI macos system
  • f2e837f: 8304350: Font.getStringBounds calculates wrong width for TextAttribute.TRACKING other than 0.0

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 22, 2023
@mlbridge
Copy link

mlbridge bot commented May 22, 2023

Webrevs

@shipilev
Copy link
Member Author

Push approval is here, testing is clean.

/integrate

@openjdk
Copy link

openjdk bot commented May 23, 2023

Going to push as commit 39a6b55.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 9cb0120: 8275233: Incorrect line number reported in exception stack trace thrown from a lambda expression
  • 32fda32: 8296343: CPVE thrown on missing content-length in OCSP response
  • 6b362e4: 8261495: Shenandoah: reconsider update references memory ordering
  • 879f4c5: 8297154: Improve safepoint cleanup logging
  • 2913a8d: 8306753: Open source several container AWT tests
  • 406d6ba: 8307378: Allow collectors to provide specific values for GC notifications' actions
  • 36c364d: 8284331: Add sanity check for signal handler modification warning.
  • 4a0f0f4: 8276058: Some swing test fails on specific CI macos system
  • f2e837f: 8304350: Font.getStringBounds calculates wrong width for TextAttribute.TRACKING other than 0.0

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 23, 2023
@openjdk openjdk bot closed this May 23, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 23, 2023
@openjdk
Copy link

openjdk bot commented May 23, 2023

@shipilev Pushed as commit 39a6b55.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8287854-dangling-class-verifier branch July 20, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant