Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8307347: serviceability/sa/ClhsdbDumpclass.java could leave files owned by root on macOS #1387

Closed

Conversation

ArnoZeller
Copy link
Contributor

@ArnoZeller ArnoZeller commented May 23, 2023


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8307347: serviceability/sa/ClhsdbDumpclass.java could leave files owned by root on macOS

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1387/head:pull/1387
$ git checkout pull/1387

Update a local copy of the PR:
$ git checkout pull/1387
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1387/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1387

View PR using the GUI difftool:
$ git pr show -t 1387

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1387.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 23, 2023

👋 Welcome back azeller! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 5c7ede94ae59b46c12d40a38bf5b7e15319cc7e2 8307347: serviceability/sa/ClhsdbDumpclass.java could leave files owned by root on macOS May 23, 2023
@openjdk
Copy link

openjdk bot commented May 23, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 23, 2023

@ArnoZeller This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307347: serviceability/sa/ClhsdbDumpclass.java could leave files owned by root on macOS

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

  • 861fe74: 8274615: Support relaxed atomic add for linux-aarch64
  • fe17568: 8307135: java/awt/dnd/NotReallySerializableTest/NotReallySerializableTest.java failed
  • 464a32b: 8227060: Optimize safepoint cleanup subtask order
  • 6033871: 8306640: Open source several AWT TextArea related tests
  • 05b2ff4: 8308554: [17u] Fix commit of 8286191. vm.musl was not removed from ExternalEditorTest
  • 9c0afc5: 8306752: Open source several container and component AWT tests
  • 4caa421: 8306755: Open source few Swing JComponent and AbstractButton tests
  • b5d3772: 8306683: Open source several clipboard and color AWT tests
  • 09e6880: 8306652: Open source AWT MenuItem related tests
  • 18ec008: 8306409: Open source AWT KeyBoardFocusManger, LightWeightComponent related tests
  • ... and 16 more: https://git.openjdk.org/jdk17u-dev/compare/2913a8dcc5081b664afa9ed06e558ac7d9ea57ea...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 23, 2023
@mlbridge
Copy link

mlbridge bot commented May 23, 2023

Webrevs

@ArnoZeller
Copy link
Contributor Author

/integrate

@MBaesken
Copy link
Member

/sponsor

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 25, 2023
@openjdk
Copy link

openjdk bot commented May 25, 2023

@ArnoZeller
Your change (at version 4e5276a) is now ready to be sponsored by a Committer.

@MBaesken
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented May 25, 2023

Going to push as commit 50aabaa.
Since your change was applied there have been 26 commits pushed to the master branch:

  • 861fe74: 8274615: Support relaxed atomic add for linux-aarch64
  • fe17568: 8307135: java/awt/dnd/NotReallySerializableTest/NotReallySerializableTest.java failed
  • 464a32b: 8227060: Optimize safepoint cleanup subtask order
  • 6033871: 8306640: Open source several AWT TextArea related tests
  • 05b2ff4: 8308554: [17u] Fix commit of 8286191. vm.musl was not removed from ExternalEditorTest
  • 9c0afc5: 8306752: Open source several container and component AWT tests
  • 4caa421: 8306755: Open source few Swing JComponent and AbstractButton tests
  • b5d3772: 8306683: Open source several clipboard and color AWT tests
  • 09e6880: 8306652: Open source AWT MenuItem related tests
  • 18ec008: 8306409: Open source AWT KeyBoardFocusManger, LightWeightComponent related tests
  • ... and 16 more: https://git.openjdk.org/jdk17u-dev/compare/2913a8dcc5081b664afa9ed06e558ac7d9ea57ea...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 25, 2023
@openjdk openjdk bot closed this May 25, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 25, 2023
@openjdk
Copy link

openjdk bot commented May 25, 2023

@MBaesken @ArnoZeller Pushed as commit 50aabaa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk
Copy link

openjdk bot commented May 25, 2023

@MBaesken The command sponsor can only be used in open pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants