Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275643: C2's unaryOp vector intrinsic does not properly handle LongVector.neg #139

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Feb 1, 2022

I backport this for parity with 17.0.3-oracle.
Requires follow-up test fix.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8275643: C2's unaryOp vector intrinsic does not properly handle LongVector.neg

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/139/head:pull/139
$ git checkout pull/139

Update a local copy of the PR:
$ git checkout pull/139
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/139/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 139

View PR using the GUI difftool:
$ git pr show -t 139

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/139.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 1, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 47564caeb0628e5c03a0e7f04093adce77d6dd3b 8275643: C2's unaryOp vector intrinsic does not properly handle LongVector.neg Feb 1, 2022
@openjdk
Copy link

openjdk bot commented Feb 1, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 1, 2022

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275643: C2's unaryOp vector intrinsic does not properly handle LongVector.neg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 1, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 1, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Feb 3, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Feb 3, 2022

Going to push as commit f723588.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 27cbe24: 8271056: C2: "assert(no_dead_loop) failed: dead loop detected" due to cmoving identity
  • ff3eec1: 8275847: Scheduling fails with "too many D-U pinch points" on small method
  • 5d54bf5: 8274944: AppCDS dump causes SEGV in VM thread while adjusting lambda proxy class info
  • e459c8c: 8275874: [JVMCI] only support aligned reads in c2v_readFieldValue
  • 0b51fe2: 8271506: Add ResourceHashtable support for deleting selected entries
  • 6cacf9a: 8278381: [GCC 11] Address::make_raw() does not initialize rspec
  • c03b95d: 8279124: VM does not handle SIGQUIT during initialization
  • 45002c0: 8277497: Last column cell in the JTable row is read as empty cell
  • 592adc8: 8278604: SwingSet2 table demo does not have accessible description set for images

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 3, 2022
@openjdk openjdk bot closed this Feb 3, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 3, 2022
@openjdk
Copy link

openjdk bot commented Feb 3, 2022

@GoeLin Pushed as commit f723588.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant