Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8300939: sun/security/provider/certpath/OCSP/OCSPNoContentLength.java fails due to network errors #1394

Closed
wants to merge 1 commit into from

Conversation

apavlyutkin
Copy link
Contributor

@apavlyutkin apavlyutkin commented May 24, 2023

Hi!

Here is backport of JDK-8300939 fixing sun/security/provider/certpath/OCSP/OCSPNoContentLength.java test. Original patch applied cleanly except removing issue record from test/jdk/ProblemList.txt.

Verification/regression (amd64/LTS20.04): jdk_security


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8300939: sun/security/provider/certpath/OCSP/OCSPNoContentLength.java fails due to network errors

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1394/head:pull/1394
$ git checkout pull/1394

Update a local copy of the PR:
$ git checkout pull/1394
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1394/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1394

View PR using the GUI difftool:
$ git pr show -t 1394

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1394.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 24, 2023

👋 Welcome back apavlyutkin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport da044dd5698d14eccd2a30a24cc691e30fa00cbd 8300939: sun/security/provider/certpath/OCSP/OCSPNoContentLength.java fails due to network errors May 24, 2023
@openjdk
Copy link

openjdk bot commented May 24, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels May 24, 2023
@mlbridge
Copy link

mlbridge bot commented May 24, 2023

Webrevs

Copy link
Member

@GoeLin GoeLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identical to orig change. LGTM

@openjdk
Copy link

openjdk bot commented May 25, 2023

@apavlyutkin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8300939: sun/security/provider/certpath/OCSP/OCSPNoContentLength.java fails due to network errors

Reviewed-by: goetz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 436d96f: 8275287: Relax memory ordering constraints on updating instance class and array class counters
  • 50aabaa: 8307347: serviceability/sa/ClhsdbDumpclass.java could leave files owned by root on macOS
  • 861fe74: 8274615: Support relaxed atomic add for linux-aarch64
  • fe17568: 8307135: java/awt/dnd/NotReallySerializableTest/NotReallySerializableTest.java failed
  • 464a32b: 8227060: Optimize safepoint cleanup subtask order
  • 6033871: 8306640: Open source several AWT TextArea related tests
  • 05b2ff4: 8308554: [17u] Fix commit of 8286191. vm.musl was not removed from ExternalEditorTest

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@GoeLin) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 25, 2023
@GoeLin
Copy link
Member

GoeLin commented May 25, 2023

HI please intergrate, I am still holding the consolidiation to jdk17u.

@apavlyutkin
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 25, 2023
@openjdk
Copy link

openjdk bot commented May 25, 2023

@apavlyutkin
Your change (at version 0b77677) is now ready to be sponsored by a Committer.

@yan-too
Copy link

yan-too commented May 25, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented May 25, 2023

Going to push as commit 57d0a7f.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 436d96f: 8275287: Relax memory ordering constraints on updating instance class and array class counters
  • 50aabaa: 8307347: serviceability/sa/ClhsdbDumpclass.java could leave files owned by root on macOS
  • 861fe74: 8274615: Support relaxed atomic add for linux-aarch64
  • fe17568: 8307135: java/awt/dnd/NotReallySerializableTest/NotReallySerializableTest.java failed
  • 464a32b: 8227060: Optimize safepoint cleanup subtask order
  • 6033871: 8306640: Open source several AWT TextArea related tests
  • 05b2ff4: 8308554: [17u] Fix commit of 8286191. vm.musl was not removed from ExternalEditorTest

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 25, 2023
@openjdk openjdk bot closed this May 25, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 25, 2023
@openjdk
Copy link

openjdk bot commented May 25, 2023

@yan-too @apavlyutkin Pushed as commit 57d0a7f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants