-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8300939: sun/security/provider/certpath/OCSP/OCSPNoContentLength.java fails due to network errors #1394
Conversation
👋 Welcome back apavlyutkin! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Identical to orig change. LGTM
@apavlyutkin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 7 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@GoeLin) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
HI please intergrate, I am still holding the consolidiation to jdk17u. |
/integrate |
@apavlyutkin |
/sponsor |
Going to push as commit 57d0a7f.
Your commit was automatically rebased without conflicts. |
@yan-too @apavlyutkin Pushed as commit 57d0a7f. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi!
Here is backport of JDK-8300939 fixing
sun/security/provider/certpath/OCSP/OCSPNoContentLength.java
test. Original patch applied cleanly except removing issue record fromtest/jdk/ProblemList.txt
.Verification/regression (amd64/LTS20.04): jdk_security
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1394/head:pull/1394
$ git checkout pull/1394
Update a local copy of the PR:
$ git checkout pull/1394
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1394/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1394
View PR using the GUI difftool:
$ git pr show -t 1394
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1394.diff
Webrev
Link to Webrev Comment