8294717: (bf) DirectByteBuffer constructor will leak if allocating Deallocator or Cleaner fails with OOME

[shipilev]

Clean backport to eliminate a leak corner case.

Additional testing:

• Linux x86_64 fastdebug tier1 tier2 tier3

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8294717: (bf) DirectByteBuffer constructor will leak if allocating Deallocator or Cleaner fails with OOME

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1396/head:pull/1396
$ git checkout pull/1396

Update a local copy of the PR:
$ git checkout pull/1396
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1396/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1396

View PR using the GUI difftool:
$ git pr show -t 1396

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1396.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294717: (bf) DirectByteBuffer constructor will leak if allocating Deallocator or Cleaner fails with OOME

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• fe17568: 8307135: java/awt/dnd/NotReallySerializableTest/NotReallySerializableTest.java failed

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (9a19443b)

[shipilev]

Push approval is here, testing is clean.

/integrate

[openjdk]

Going to push as commit 14779b1.
Since your change was applied there have been 5 commits pushed to the master branch:

• 57d0a7f: 8300939: sun/security/provider/certpath/OCSP/OCSPNoContentLength.java fails due to network errors
• 436d96f: 8275287: Relax memory ordering constraints on updating instance class and array class counters
• 50aabaa: 8307347: serviceability/sa/ClhsdbDumpclass.java could leave files owned by root on macOS
• 861fe74: 8274615: Support relaxed atomic add for linux-aarch64
• fe17568: 8307135: java/awt/dnd/NotReallySerializableTest/NotReallySerializableTest.java failed

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 14779b1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.