Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8300053: Shenandoah: Handle more GCCauses in ShenandoahControlThread::request_gc #1409

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented May 30, 2023

Clean backport to catch a corner case for Shenandoah.

Additional testing:

  • macos-aarch64-server-fastdebug build
  • GHA

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8300053: Shenandoah: Handle more GCCauses in ShenandoahControlThread::request_gc

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1409/head:pull/1409
$ git checkout pull/1409

Update a local copy of the PR:
$ git checkout pull/1409
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1409/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1409

View PR using the GUI difftool:
$ git pr show -t 1409

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1409.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 30, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport cac72a60181d3570562f8534c691528d06e40cb8 8300053: Shenandoah: Handle more GCCauses in ShenandoahControlThread::request_gc May 30, 2023
@openjdk
Copy link

openjdk bot commented May 30, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 30, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8300053: Shenandoah: Handle more GCCauses in ShenandoahControlThread::request_gc

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

  • 7765ba5: 8292698: Improve performance of DataInputStream
  • 3d30c29: 8309107: Bump update version for OpenJDK: jdk-17.0.9
  • a93cf5f: 8308884: [17u/11u] Backout JDK-8297951
  • 8f65a6d: 8287876: The recently de-problemlisted TestTitledBorderLeak test is unstable
  • 109cc49: 8308880: [17u] micro bench ZoneStrings missed in backport of 8278434
  • de8ec1d: 8293492: ShenandoahControlThread missing from hs-err log and thread dump
  • ff0ee6d: 8301637: ThreadLocalRandom.current().doubles().parallel() contention
  • bc78e07: 8293295: Add type check asserts to java_lang_ref_Reference accessors
  • 213d0db: 8294183: AArch64: Wrong macro check in SharedRuntime::generate_deopt_blob
  • b10ac57: 8274243: Implement fast-path for ASCII-compatible CharsetEncoders on aarch64
  • ... and 3 more: https://git.openjdk.org/jdk17u-dev/compare/6287df05cee5781da1c223ed6084d0b2fcc6959b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 30, 2023
@mlbridge
Copy link

mlbridge bot commented May 30, 2023

Webrevs

@shipilev
Copy link
Member Author

Push approval is here. Testing is clean.

/integrate

@openjdk
Copy link

openjdk bot commented May 31, 2023

Going to push as commit c1e979f.
Since your change was applied there have been 14 commits pushed to the master branch:

  • c9013a2: 8298138: Shenandoah: HdrSeq asserts "sub-bucket index (512) overflow for value ( 1.00)"
  • 7765ba5: 8292698: Improve performance of DataInputStream
  • 3d30c29: 8309107: Bump update version for OpenJDK: jdk-17.0.9
  • a93cf5f: 8308884: [17u/11u] Backout JDK-8297951
  • 8f65a6d: 8287876: The recently de-problemlisted TestTitledBorderLeak test is unstable
  • 109cc49: 8308880: [17u] micro bench ZoneStrings missed in backport of 8278434
  • de8ec1d: 8293492: ShenandoahControlThread missing from hs-err log and thread dump
  • ff0ee6d: 8301637: ThreadLocalRandom.current().doubles().parallel() contention
  • bc78e07: 8293295: Add type check asserts to java_lang_ref_Reference accessors
  • 213d0db: 8294183: AArch64: Wrong macro check in SharedRuntime::generate_deopt_blob
  • ... and 4 more: https://git.openjdk.org/jdk17u-dev/compare/6287df05cee5781da1c223ed6084d0b2fcc6959b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 31, 2023
@openjdk openjdk bot closed this May 31, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 31, 2023
@openjdk
Copy link

openjdk bot commented May 31, 2023

@shipilev Pushed as commit c1e979f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8300053-shenandoah-more-gc-causes branch July 20, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant