Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278381: [GCC 11] Address::make_raw() does not initialize rspec #141

Closed
wants to merge 1 commit into from

Conversation

phohensee
Copy link
Member

@phohensee phohensee commented Feb 1, 2022

Trivial gcc 11 compatibility patch, applies cleanly.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8278381: [GCC 11] Address::make_raw() does not initialize rspec

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/141/head:pull/141
$ git checkout pull/141

Update a local copy of the PR:
$ git checkout pull/141
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/141/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 141

View PR using the GUI difftool:
$ git pr show -t 141

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/141.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 1, 2022

👋 Welcome back phh! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 4f594e6a28ad85d46d3252fb960f1c116f414899 8278381: [GCC 11] Address::make_raw() does not initialize rspec Feb 1, 2022
@openjdk
Copy link

openjdk bot commented Feb 1, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 1, 2022

@phohensee This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278381: [GCC 11] Address::make_raw() does not initialize rspec

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • 45002c0: 8277497: Last column cell in the JTable row is read as empty cell
  • 592adc8: 8278604: SwingSet2 table demo does not have accessible description set for images
  • 952f9c7: 8275645: [JVMCI] avoid unaligned volatile reads on AArch64
  • 869bb36: 8280414: Memory leak in DefaultProxySelector
  • c581598: 8273381: Assert in PtrQueueBufferAllocatorTest.stress_free_list_allocator_vm
  • cb769c0: 8269616: serviceability/dcmd/framework/VMVersionTest.java fails with Address already in use error
  • ac8a550: 8280155: [PPC64, s390] frame size checks are not yet correct
  • 22a6279: 8279924: [PPC64, s390] implement frame::is_interpreted_frame_valid checks
  • 7a5a8ab: 8280526: x86_32 Math.sqrt performance regression with -XX:UseSSE={0,1}
  • d34650a: 8279076: C2: Bad AD file when matching SqrtF with UseSSE=0
  • ... and 4 more: https://git.openjdk.java.net/jdk17u-dev/compare/a93e5efee2fc5807444c5720d31451d600022662...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 1, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 1, 2022

Webrevs

@phohensee
Copy link
Member Author

Approved.

/integrate

@openjdk
Copy link

openjdk bot commented Feb 2, 2022

Going to push as commit 6cacf9a.
Since your change was applied there have been 15 commits pushed to the master branch:

  • c03b95d: 8279124: VM does not handle SIGQUIT during initialization
  • 45002c0: 8277497: Last column cell in the JTable row is read as empty cell
  • 592adc8: 8278604: SwingSet2 table demo does not have accessible description set for images
  • 952f9c7: 8275645: [JVMCI] avoid unaligned volatile reads on AArch64
  • 869bb36: 8280414: Memory leak in DefaultProxySelector
  • c581598: 8273381: Assert in PtrQueueBufferAllocatorTest.stress_free_list_allocator_vm
  • cb769c0: 8269616: serviceability/dcmd/framework/VMVersionTest.java fails with Address already in use error
  • ac8a550: 8280155: [PPC64, s390] frame size checks are not yet correct
  • 22a6279: 8279924: [PPC64, s390] implement frame::is_interpreted_frame_valid checks
  • 7a5a8ab: 8280526: x86_32 Math.sqrt performance regression with -XX:UseSSE={0,1}
  • ... and 5 more: https://git.openjdk.java.net/jdk17u-dev/compare/a93e5efee2fc5807444c5720d31451d600022662...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 2, 2022
@openjdk openjdk bot closed this Feb 2, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 2, 2022
@openjdk
Copy link

openjdk bot commented Feb 2, 2022

@phohensee Pushed as commit 6cacf9a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@phohensee phohensee deleted the backport-4f594e6a branch February 10, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant