Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8298921: Create a regression test for JDK-8139581 #1429

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jun 13, 2023

I backport this for parity with 17.0.8-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8298921: Create a regression test for JDK-8139581 (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1429/head:pull/1429
$ git checkout pull/1429

Update a local copy of the PR:
$ git checkout pull/1429
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1429/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1429

View PR using the GUI difftool:
$ git pr show -t 1429

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1429.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 13, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 834e50e9efc16effad7469cae99ab8f918a30e86 8298921: Create a regression test for JDK-8139581 Jun 13, 2023
@openjdk
Copy link

openjdk bot commented Jun 13, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 13, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298921: Create a regression test for JDK-8139581

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 13, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 13, 2023

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Jun 15, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jun 15, 2023

Going to push as commit 31a7fd3.
Since your change was applied there have been 7 commits pushed to the master branch:

  • faafe22: 8305858: Resolve multiple definition of 'handleSocketError' when statically linking with JDK native libraries
  • 01ac9cb: 8309138: Fix container tests for jdks with symlinked conf dir
  • 6991372: 8305995: Footprint regression from JDK-8224957
  • 2570e72: 8308300: enhance exceptions in MappedMemoryUtils.c
  • ebb9a36: 8309297: Adjust ShenandoahHeap print_heap_regions_on
  • 8ac9c57: Merge
  • 0f531da: 8303465: KeyStore of type KeychainStore, provider Apple does not show all trusted certificates

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 15, 2023
@openjdk openjdk bot closed this Jun 15, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 15, 2023
@openjdk
Copy link

openjdk bot commented Jun 15, 2023

@GoeLin Pushed as commit 31a7fd3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant