8309959: JFR: Display N/A for missing data amount

[fthevenet]

This is a backport of JDK-8309959: JFR: Display N/A for missing data amount.

It is a follow up to the backport of JDK-8309550: jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE

NB: ValueFormatter.java that is changed in the original commit got introduced with JDK-8306703. which is JDK 21+ only and shouldn't get backported.

A run of the Jdk_jfr test suite via GHA is available here: https://github.com/fthevenet/jdk17u-dev/actions/runs/5267901714

Thanks

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8309959: JFR: Display N/A for missing data amount (Bug - P3)

Reviewers

• Thomas Stuefe (@tstuefe - Reviewer) ⚠️ Review applies to d7b25378
• Severin Gehwolf (@jerboaa - Reviewer) ⚠️ Review applies to d7b25378

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1438/head:pull/1438
$ git checkout pull/1438

Update a local copy of the PR:
$ git checkout pull/1438
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1438/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1438

View PR using the GUI difftool:
$ git pr show -t 1438

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1438.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back fthevenet! A progress list of the required criteria for merging this PR into pr/1423 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 02: Full - Incremental (52f5571b)
• 01: Full - Incremental (d7b25378)
• 00: Full (d7b25378)

[tstuefe]

Okay

[jerboaa]

LGTM

[openjdk-notifier]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout backport_8309959
git fetch https://git.openjdk.org/jdk17u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

@fthevenet This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309959: JFR: Display N/A for missing data amount

Reviewed-by: stuefe, sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 6c81bf5: 8295811: serviceability/sa/TestObjectAlignment.java fails on x86_32
• c6f6db2: 8295657: SA: Allow larger object alignments
• 55c0eaa: 8272654: Mark word accesses should not use Access API

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@tstuefe, @jerboaa) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@fthevenet Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[fthevenet]

/integrate

[openjdk]

@fthevenet
Your change (at version 52f5571) is now ready to be sponsored by a Committer.

[jerboaa]

/sponsor

[openjdk]

Going to push as commit 5a4e374.
Since your change was applied there have been 3 commits pushed to the master branch:

• 6c81bf5: 8295811: serviceability/sa/TestObjectAlignment.java fails on x86_32
• c6f6db2: 8295657: SA: Allow larger object alignments
• 55c0eaa: 8272654: Mark word accesses should not use Access API

Your commit was automatically rebased without conflicts.

[openjdk]

@jerboaa @fthevenet Pushed as commit 5a4e374.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.