8276696: ParallelObjectIterator freed at the wrong time in VM_HeapDumper

[shipilev]

Unclean backport to improve the heap dumping code for cleaner JDK-8307348 backport. This backport is not clean, because it misses the parts of HeapDumper introduced by JDK-8252842, which I don't want to backport at all in 17u, given the large bugtail for it.

Additional testing:

• Linux x86_64 fastdebug jdk/jfr serviceability/sa
• Linux x86_64 fastdebug tier1 tier2 tier3
• Linux AArch64 fastdebug tier1 tier2 tier3

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8276696: ParallelObjectIterator freed at the wrong time in VM_HeapDumper (Bug - P3)

Reviewers

• Oli Gillespie (@olivergillespie - no project role)
• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1440/head:pull/1440
$ git checkout pull/1440

Update a local copy of the PR:
$ git checkout pull/1440
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1440/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1440

View PR using the GUI difftool:
$ git pr show -t 1440

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1440.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (37dd9b23)

[phohensee]

Lgtm.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276696: ParallelObjectIterator freed at the wrong time in VM_HeapDumper

Reviewed-by: ogillespie, phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 81 new commits pushed to the master branch:

• a72bdbf: 8303047: avoid NULL after 8301661
• 62140e2: 8290469: Add new positioning options to PassFailJFrame test framework
• a563c45: 8306682: Open source a few more AWT Choice tests
• a424cdd: 8306484: Open source several AWT Choice jtreg tests
• 7f8e1de: 8306430: Open source some AWT tests related to TextComponent and Toolkit
• 2d26f38: 8306372: Open source AWT CardLayout and Checkbox tests
• 4013216: 8306134: Open source some AWT tests relating to Button and a few other classes
• 0b0c61e: 8289077: Add manual tests to open
• 99c7ade: 8301074: Replace NULL with nullptr in share/opto/
• 1472676: 8269466: Factor out the common code for initializing and starting internal VM JavaThreads
• ... and 71 more: https://git.openjdk.org/jdk17u-dev/compare/6991372a06f7e623112f1437eeaed7ad7eb6eb99...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

Reviews are here, testing is clean, push approval is here.

/integrate

[openjdk]

Going to push as commit b7c1456.
Since your change was applied there have been 96 commits pushed to the master branch:

• e28a5ea: 8280885: Shenandoah: Some tests failed with "EA: missing allocation reference path"
• 90345a4: 8308766: TLAB initialization may cause div by zero
• 4d261ef: 8300693: Lower the compile threshold and reduce the iterations of warmup loop in VarHandles tests
• cf868a5: 8171221: Remove -XX:+CheckMemoryInitialization
• 42caa28: 8300405: Screen capture for test JFileChooserSetLocationTest.java, failure case
• ce054c9: 8284760: Correct type/array element offset in LibraryCallKit::get_state_from_digest_object()
• 8d6c17d: 8270894: Use acquire semantics in ObjectSynchronizer::read_stable_mark()
• 00c6470: 8270794: Avoid loading Klass* twice in TypeArrayKlass::oop_size()
• 43d4d02: 8300098: java/util/concurrent/ConcurrentHashMap/ConcurrentAssociateTest.java fails with internal timeout when executed with TieredCompilation1/3
• 71f17d9: 8293811: Provide a reason for PassFailJFrame.forceFail
• ... and 86 more: https://git.openjdk.org/jdk17u-dev/compare/6991372a06f7e623112f1437eeaed7ad7eb6eb99...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit b7c1456.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.