Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267188: gc/stringdedup/TestStringDeduplicationInterned.java fails with Shenandoah #1447

Closed

Conversation

earthling-amzn
Copy link

@earthling-amzn earthling-amzn commented Jun 15, 2023

Unclean backport of JDK-8267188.

Conflict in TestStringDeduplicationInterned.java was easily resolved.

Testing:

  • hotspot_gc_shenandoah
  • dacapo
  • extremem
  • specjbb2015
  • hyperalloc

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8267188: gc/stringdedup/TestStringDeduplicationInterned.java fails with Shenandoah (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1447/head:pull/1447
$ git checkout pull/1447

Update a local copy of the PR:
$ git checkout pull/1447
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1447/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1447

View PR using the GUI difftool:
$ git pr show -t 1447

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1447.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 15, 2023

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7212561dd1ec65d7f31792959f0eaaab6229eaf4 8267188: gc/stringdedup/TestStringDeduplicationInterned.java fails with Shenandoah Jun 15, 2023
@openjdk
Copy link

openjdk bot commented Jun 15, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 15, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 15, 2023

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Jun 16, 2023

Please only labe PRs that are ready with fix-request:

  • tests are failing
  • review missing.

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Jun 16, 2023

@earthling-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267188: gc/stringdedup/TestStringDeduplicationInterned.java fails with Shenandoah

Reviewed-by: phh, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 34 new commits pushed to the master branch:

  • 48d7af6: 8263044: jdk/jfr/jvm/TestDumpOnCrash.java timed out
  • 5ec9b86: 8274986: max code printed in hs-err logs should be configurable
  • 878cea2: 8252713: jtreg time out of CtrlASCII.java seems to hang the Xserver.
  • 9824e64: 8291830: jvmti/RedefineClasses/StressRedefine failed: assert(!is_null(v)) failed: narrow klass value can never be zero
  • 2e5a402: 8293012: ConstantPool::print_on can crash if _cache is NULL
  • fb1741c: 8309956: Shenandoah: Strengthen the mark word check in string dedup
  • 3773e0b: 8309228: Clarify EXPERIMENTAL flags comment in hotspot/share/runtime/globals.hpp
  • aa3b4e4: 8305236: Some LoadLoad barriers in the interpreter are unnecessary after JDK-8220051
  • bda6723: 8282665: [REDO] ByteBufferTest.java: replace endless recursion with RuntimeException in void ck(double x, double y)
  • 393aeaf: 8272586: emit abstract machine code in hs-err logs
  • ... and 24 more: https://git.openjdk.org/jdk17u-dev/compare/f9a60759b13f242c45bef8506e25ffea3e972247...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee, @shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 16, 2023
@phohensee
Copy link
Member

phohensee commented Jun 16, 2023

I can't reproduce the pre-submit test failure of TestMetaspacePerfCounters.java on my Amazon Linux box. The specific failure is

assertGTE(capacity, used);

This PR doesn't touch the code associated with the perf counters, so the failure looks unrelated. There may be a race between metaspace expansion and perf counter updates.

@earthling-amzn
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 20, 2023
@openjdk
Copy link

openjdk bot commented Jun 20, 2023

@earthling-amzn
Your change (at version a6859c0) is now ready to be sponsored by a Committer.

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@shipilev
Copy link
Member

Reviews are here. Tests seem to be failing due to infrastructure problems. @earthling-amzn, could you please trigger GHA run again?

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 21, 2023

Going to push as commit 9a49698.
Since your change was applied there have been 34 commits pushed to the master branch:

  • 48d7af6: 8263044: jdk/jfr/jvm/TestDumpOnCrash.java timed out
  • 5ec9b86: 8274986: max code printed in hs-err logs should be configurable
  • 878cea2: 8252713: jtreg time out of CtrlASCII.java seems to hang the Xserver.
  • 9824e64: 8291830: jvmti/RedefineClasses/StressRedefine failed: assert(!is_null(v)) failed: narrow klass value can never be zero
  • 2e5a402: 8293012: ConstantPool::print_on can crash if _cache is NULL
  • fb1741c: 8309956: Shenandoah: Strengthen the mark word check in string dedup
  • 3773e0b: 8309228: Clarify EXPERIMENTAL flags comment in hotspot/share/runtime/globals.hpp
  • aa3b4e4: 8305236: Some LoadLoad barriers in the interpreter are unnecessary after JDK-8220051
  • bda6723: 8282665: [REDO] ByteBufferTest.java: replace endless recursion with RuntimeException in void ck(double x, double y)
  • 393aeaf: 8272586: emit abstract machine code in hs-err logs
  • ... and 24 more: https://git.openjdk.org/jdk17u-dev/compare/f9a60759b13f242c45bef8506e25ffea3e972247...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 21, 2023
@openjdk openjdk bot closed this Jun 21, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 21, 2023
@openjdk
Copy link

openjdk bot commented Jun 21, 2023

@phohensee @earthling-amzn Pushed as commit 9a49698.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
4 participants