8277654: Shenandoah: Don't produce new memory state in C2 LRB runtime call#1448
8277654: Shenandoah: Don't produce new memory state in C2 LRB runtime call#1448earthling-amzn wants to merge 2 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
|
@earthling-amzn This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 31 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
Webrevs
|
|
I think it needs JDK-8287227 as the follow-up too, see linked issues in the JIRA. |
|
Should JDK-8287227 come in a separate PR? or should I cherry-pick that change into this PR? |
What you did is right: a dependent PR. Get the push approval for both PRs, and then integrate them one by one. |
|
/integrate |
|
@earthling-amzn |
|
/sponsor |
|
Going to push as commit b8a65e0.
Your commit was automatically rebased without conflicts. |
|
@shipilev @earthling-amzn Pushed as commit b8a65e0. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Testing:
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1448/head:pull/1448$ git checkout pull/1448Update a local copy of the PR:
$ git checkout pull/1448$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1448/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1448View PR using the GUI difftool:
$ git pr show -t 1448Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1448.diff
Webrev
Link to Webrev Comment