Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273559: Shenandoah: Shenandoah should support multi-threaded heap dump #1450

Closed

Conversation

earthling-amzn
Copy link

@earthling-amzn earthling-amzn commented Jun 15, 2023

Unclean backport of JDK-8273559

Testing:

  • hotspot_gc_shenandoah
  • dacapo
  • extremem
  • specjbb2015
  • hyperalloc

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8273559: Shenandoah: Shenandoah should support multi-threaded heap dump (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1450/head:pull/1450
$ git checkout pull/1450

Update a local copy of the PR:
$ git checkout pull/1450
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1450/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1450

View PR using the GUI difftool:
$ git pr show -t 1450

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1450.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 15, 2023

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8132bfd23f2f7fb52e502a3e6fe488fbdb537df0 8273559: Shenandoah: Shenandoah should support multi-threaded heap dump Jun 15, 2023
@openjdk
Copy link

openjdk bot commented Jun 15, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 15, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 15, 2023

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. langtools presubmit test failure appears unrelated.

@openjdk
Copy link

openjdk bot commented Jun 21, 2023

@earthling-amzn This change is no longer ready for integration - check the PR body for details.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 21, 2023
@earthling-amzn earthling-amzn marked this pull request as draft June 26, 2023 16:35
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 26, 2023
@earthling-amzn
Copy link
Author

Withdrawing this pull request because the backport is unclean and there are assertions from the deadlock detector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants