Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267341: macos attempt_reserve_memory_at(arg1, arg2, true) failure #1451

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jun 16, 2023

I backport this for parity with 17.0.8-oracle.

I had to resolve one hunk because the bugId did not match.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8267341: macos attempt_reserve_memory_at(arg1, arg2, true) failure (Bug - P3)
  • JDK-8271898: disable os.release_multi_mappings_vm on macOS-X64 (Sub-task - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1451/head:pull/1451
$ git checkout pull/1451

Update a local copy of the PR:
$ git checkout pull/1451
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1451/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1451

View PR using the GUI difftool:
$ git pr show -t 1451

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1451.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 16, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 16, 2023

⚠️ @GoeLin the given backport hash 237fee8bbdc7f239aa18b7780392ff3222589914 is an ancestor of your proposed change. Please update the title with the hash for the change you are backporting.

@GoeLin GoeLin changed the title Backport 237fee8bbdc7f239aa18b7780392ff3222589914 Backport d1efb0cc56127a40f2b23ccc608b27be2b39a389 Jun 16, 2023
@openjdk openjdk bot changed the title Backport d1efb0cc56127a40f2b23ccc608b27be2b39a389 8267341: macos attempt_reserve_memory_at(arg1, arg2, true) failure Jun 16, 2023
@openjdk
Copy link

openjdk bot commented Jun 16, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 16, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 16, 2023

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Jun 16, 2023

/issue JDK-8271898

This needs not be backported any more.

@openjdk
Copy link

openjdk bot commented Jun 16, 2023

@GoeLin
Adding additional issue to issue list: 8271898: disable os.release_multi_mappings_vm on macOS-X64.

Copy link

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Jun 16, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267341: macos attempt_reserve_memory_at(arg1, arg2, true) failure
8271898: disable os.release_multi_mappings_vm on macOS-X64

Reviewed-by: lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • eed854c: 8309340: Provide sctpHandleSocketErrorWithMessage

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 16, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Jun 19, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jun 19, 2023

Going to push as commit dd9cefd.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 7f2344b: 8278456: Define jtreg jdk_desktop test group time-based sub-tasks for use by headful testing.
  • 9181535: 8300584: Accelerate AVX-512 CRC32C for small buffers
  • 2b5b9f5: 8289748: C2 compiled code crashes with SIGFPE with -XX:+StressLCM and -XX:+StressGCM
  • 2bed865: 8271707: migrate tests to use jdk.test.whitebox.WhiteBox
  • eed854c: 8309340: Provide sctpHandleSocketErrorWithMessage

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 19, 2023
@openjdk openjdk bot closed this Jun 19, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 19, 2023
@openjdk
Copy link

openjdk bot commented Jun 19, 2023

@GoeLin Pushed as commit dd9cefd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8267341 branch June 19, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants