Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8295657: SA: Allow larger object alignments #1457

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Jun 16, 2023

Improves SA support for larger alignments.

Needs a follow-up backport to fix x86_32.

Additional testing:

  • New test fails without a fix, passes with the fix
  • Linux x86_64 fastdebug serviceability/sa

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8295657: SA: Allow larger object alignments (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1457/head:pull/1457
$ git checkout pull/1457

Update a local copy of the PR:
$ git checkout pull/1457
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1457/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1457

View PR using the GUI difftool:
$ git pr show -t 1457

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1457.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 16, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport dfd2d83144fe4d78a7144acda6d9cb3e0045ea70 8295657: SA: Allow larger object alignments Jun 16, 2023
@openjdk
Copy link

openjdk bot commented Jun 16, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 16, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295657: SA: Allow larger object alignments

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 9181535: 8300584: Accelerate AVX-512 CRC32C for small buffers
  • 2b5b9f5: 8289748: C2 compiled code crashes with SIGFPE with -XX:+StressLCM and -XX:+StressGCM
  • 2bed865: 8271707: migrate tests to use jdk.test.whitebox.WhiteBox
  • eed854c: 8309340: Provide sctpHandleSocketErrorWithMessage
  • f9a6075: 8302150: Speed up compiler/codegen/Test7100757.java
  • 954bbaa: 8282651: ZGC: vmTestbase/gc/ArrayJuggle/ tests fails intermittently with exit code 97
  • 30d0484: 8299962: Speed up compiler/intrinsics/unsafe/DirectByteBufferTest.java and HeapByteBufferTest.java
  • 31a7fd3: 8298921: Create a regression test for JDK-8139581
  • faafe22: 8305858: Resolve multiple definition of 'handleSocketError' when statically linking with JDK native libraries
  • 01ac9cb: 8309138: Fix container tests for jdks with symlinked conf dir

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 16, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 16, 2023

Webrevs

@shipilev
Copy link
Member Author

Testing is clean. Backport is clean. Push approval is here.

/integrate

@openjdk
Copy link

openjdk bot commented Jun 19, 2023

Going to push as commit c6f6db2.
Since your change was applied there have been 23 commits pushed to the master branch:

  • 55c0eaa: 8272654: Mark word accesses should not use Access API
  • 7697ab4: 8309550: jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE
  • 852c26c: 8279545: Buffer overrun in reverse_words of sharedRuntime_x86_64.cpp:3517
  • 5fc07b5: 8305815: Update Libpng to 1.6.39
  • 9dd23ff: 8292315: Tests should not rely on specific JAR file names (hotspot)
  • f21f9a4: 8292316: Tests should not rely on specific JAR file names (jpackage)
  • 01369a6: 8285756: clean up use of bad arguments for @clean in langtools tests
  • 4bbead6: 8286620: Create regression test for verifying setMargin() of JRadioButton
  • 24b31cd: 8280396: G1: Full gc mark stack draining should prefer to make work available to other threads
  • 1258a71: 8281507: Two javac tests have bad jtreg @clean tags
  • ... and 13 more: https://git.openjdk.org/jdk17u-dev/compare/6991372a06f7e623112f1437eeaed7ad7eb6eb99...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 19, 2023
@openjdk openjdk bot closed this Jun 19, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 19, 2023
@openjdk
Copy link

openjdk bot commented Jun 19, 2023

@shipilev Pushed as commit c6f6db2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8295657-sa-larger-alignments branch July 20, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant