8295811: serviceability/sa/TestObjectAlignment.java fails on x86_32#1458
8295811: serviceability/sa/TestObjectAlignment.java fails on x86_32#1458shipilev wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
c8f6833 to
383709b
Compare
|
@shipilev Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
|
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
Push approval is here. Previous testing was clean. /integrate |
|
Going to push as commit 6c81bf5. |
Clean backport to unbreak x86_32.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1458/head:pull/1458$ git checkout pull/1458Update a local copy of the PR:
$ git checkout pull/1458$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1458/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1458View PR using the GUI difftool:
$ git pr show -t 1458Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1458.diff
Webrev
Link to Webrev Comment