Skip to content

8295811: serviceability/sa/TestObjectAlignment.java fails on x86_32#1458

Closed
shipilev wants to merge 1 commit intoopenjdk:masterfrom
shipilev:JDK-8295811-sa-fix-x86-32
Closed

8295811: serviceability/sa/TestObjectAlignment.java fails on x86_32#1458
shipilev wants to merge 1 commit intoopenjdk:masterfrom
shipilev:JDK-8295811-sa-fix-x86-32

Conversation

@shipilev
Copy link
Member

@shipilev shipilev commented Jun 16, 2023

Clean backport to unbreak x86_32.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8295811: serviceability/sa/TestObjectAlignment.java fails on x86_32 (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1458/head:pull/1458
$ git checkout pull/1458

Update a local copy of the PR:
$ git checkout pull/1458
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1458/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1458

View PR using the GUI difftool:
$ git pr show -t 1458

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1458.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 16, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into pr/1457 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7cbf6721dcae6b0c22a57838d8dd769d87df9127 8295811: serviceability/sa/TestObjectAlignment.java fails on x86_32 Jun 16, 2023
@openjdk
Copy link

openjdk bot commented Jun 16, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review labels Jun 16, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 16, 2023

Webrevs

@shipilev shipilev force-pushed the JDK-8295811-sa-fix-x86-32 branch from c8f6833 to 383709b Compare June 19, 2023 13:45
@shipilev shipilev changed the base branch from pr/1457 to master June 19, 2023 13:45
@openjdk
Copy link

openjdk bot commented Jun 19, 2023

@shipilev Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk
Copy link

openjdk bot commented Jun 19, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295811: serviceability/sa/TestObjectAlignment.java fails on x86_32

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 19, 2023
@shipilev
Copy link
Member Author

Push approval is here. Previous testing was clean.
The patch is trivial, so I would not wait for GHA respin.

/integrate

@openjdk
Copy link

openjdk bot commented Jun 19, 2023

Going to push as commit 6c81bf5.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 19, 2023
@openjdk openjdk bot closed this Jun 19, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 19, 2023
@openjdk
Copy link

openjdk bot commented Jun 19, 2023

@shipilev Pushed as commit 6c81bf5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8295811-sa-fix-x86-32 branch July 20, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant