Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8270117: Broken jtreg link in "Building the JDK" page #146

Closed
wants to merge 1 commit into from

Conversation

jmtd
Copy link

@jmtd jmtd commented Feb 4, 2022

Hi all,

This pull request contains a backport of commit 41a5eb43 from the openjdk/jdk repository.

The commit being backported was authored by Magnus Ihse Bursie on 12 Jul 2021 and was reviewed by Severin Gehwolf.

It's a very minor doc fix but I tripped over the broken URI in jdk17u-dev just now (I'm getting back
into backports work after a hiatus) so felt it was worthy of consideration.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8270117: Broken jtreg link in "Building the JDK" page

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/146/head:pull/146
$ git checkout pull/146

Update a local copy of the PR:
$ git checkout pull/146
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/146/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 146

View PR using the GUI difftool:
$ git pr show -t 146

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/146.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 4, 2022

👋 Welcome back jdowland! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 41a5eb437204a650d6cc271f41e1d186ee812a88 8270117: Broken jtreg link in "Building the JDK" page Feb 4, 2022
@openjdk
Copy link

openjdk bot commented Feb 4, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 4, 2022

@jmtd This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270117: Broken jtreg link in "Building the JDK" page

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

  • 0e5810d: 8274171: java/nio/file/Files/probeContentType/Basic.java failed on "Content type" mismatches
  • 2011c35: 8274562: (fs) UserDefinedFileAttributeView doesn't correctly determine if supported when using OverlayFS
  • ab3dd20: 8273655: content-types.properties files are missing some common types
  • a7010a2: 8279385: [test] Adjust sun/security/pkcs12/KeytoolOpensslInteropTest.java after 8278344
  • 7833c7d: 8280373: Update Xalan serializer / SystemIDResolver to align with JDK-8270492
  • 8207e69: 8272541: Incorrect overflow test in Toom-Cook branch of BigInteger multiplication
  • ec1733d: 8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10
  • 6cee018: 8272600: (test) Use native "sleep" in Basic.java
  • 87010e7: 8271199: Mutual TLS handshake fails signing client certificate with custom sensitive PKCS11 key
  • 2965051: 8277299: STACK_OVERFLOW in Java_sun_awt_shell_Win32ShellFolder2_getIconBits
  • ... and 6 more: https://git.openjdk.java.net/jdk17u-dev/compare/dba064ae107120109f792909475810afde7705e8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 4, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 4, 2022

Webrevs

@jmtd
Copy link
Author

jmtd commented Feb 16, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 16, 2022
@openjdk
Copy link

openjdk bot commented Feb 16, 2022

@jmtd
Your change (at version ed2bdc5) is now ready to be sponsored by a Committer.

@TheRealMDoerr
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 21, 2022

Going to push as commit f7f0b31.
Since your change was applied there have been 21 commits pushed to the master branch:

  • cf55b1b: 8279695: [TESTBUG] modify compiler/loopopts/TestSkeletonPredicateNegation.java to run on C1 also
  • f6afde2: 8278080: Add --with-cacerts-src='user cacerts folder' to enable deterministic cacerts generation
  • 63fe160: 8277762: Allow configuration of HOTSPOT_BUILD_USER
  • d54675b: 8274524: SSLSocket.close() hangs if it is called during the ssl handshake
  • a59e8cb: 8278346: java/nio/file/Files/probeContentType/Basic.java fails on Linux SLES15 machine
  • 0e5810d: 8274171: java/nio/file/Files/probeContentType/Basic.java failed on "Content type" mismatches
  • 2011c35: 8274562: (fs) UserDefinedFileAttributeView doesn't correctly determine if supported when using OverlayFS
  • ab3dd20: 8273655: content-types.properties files are missing some common types
  • a7010a2: 8279385: [test] Adjust sun/security/pkcs12/KeytoolOpensslInteropTest.java after 8278344
  • 7833c7d: 8280373: Update Xalan serializer / SystemIDResolver to align with JDK-8270492
  • ... and 11 more: https://git.openjdk.java.net/jdk17u-dev/compare/dba064ae107120109f792909475810afde7705e8...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 21, 2022
@openjdk openjdk bot closed this Feb 21, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 21, 2022
@openjdk
Copy link

openjdk bot commented Feb 21, 2022

@TheRealMDoerr @jmtd Pushed as commit f7f0b31.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants