Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8292315: Tests should not rely on specific JAR file names (hotspot) #1461

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jun 16, 2023

I backport this to enable jtreg 7.

I needed to add an import.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8292315: Tests should not rely on specific JAR file names (hotspot) (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1461/head:pull/1461
$ git checkout pull/1461

Update a local copy of the PR:
$ git checkout pull/1461
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1461/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1461

View PR using the GUI difftool:
$ git pr show -t 1461

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1461.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 16, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 62a7fc60d3b3a27525fc01930834dab6f89bd451 8292315: Tests should not rely on specific JAR file names (hotspot) Jun 16, 2023
@openjdk
Copy link

openjdk bot commented Jun 16, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 16, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 16, 2023

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Jun 16, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292315: Tests should not rely on specific JAR file names (hotspot)

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 16, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Jun 19, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jun 19, 2023

Going to push as commit 9dd23ff.
Since your change was applied there have been 8 commits pushed to the master branch:

  • f21f9a4: 8292316: Tests should not rely on specific JAR file names (jpackage)
  • 01369a6: 8285756: clean up use of bad arguments for @clean in langtools tests
  • 4bbead6: 8286620: Create regression test for verifying setMargin() of JRadioButton
  • 24b31cd: 8280396: G1: Full gc mark stack draining should prefer to make work available to other threads
  • 1258a71: 8281507: Two javac tests have bad jtreg @clean tags
  • 75a911c: 8209398: sun/security/pkcs11/KeyStore/SecretKeysBasic.sh failed with "PKCS11Exception: CKR_ATTRIBUTE_SENSITIVE"
  • dd9cefd: 8267341: macos attempt_reserve_memory_at(arg1, arg2, true) failure
  • 7f2344b: 8278456: Define jtreg jdk_desktop test group time-based sub-tasks for use by headful testing.

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 19, 2023
@openjdk openjdk bot closed this Jun 19, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 19, 2023
@openjdk
Copy link

openjdk bot commented Jun 19, 2023

@GoeLin Pushed as commit 9dd23ff.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8292315 branch June 19, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants