Skip to content

8307569: Build with gcc8 is broken after JDK-8307301 #1466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jun 19, 2023

I backport this for parity with 17.0.9-oracle.

I had to resolve, In 17, there are much more warnings disabled.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8307569: Build with gcc8 is broken after JDK-8307301 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1466/head:pull/1466
$ git checkout pull/1466

Update a local copy of the PR:
$ git checkout pull/1466
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1466/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1466

View PR using the GUI difftool:
$ git pr show -t 1466

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1466.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 19, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 64c09628664fd19c281723f15bf677c52e360acd 8307569: Build with gcc8 is broken after JDK-8307301 Jun 19, 2023
@openjdk
Copy link

openjdk bot commented Jun 19, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 19, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 19, 2023

Webrevs

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine!

@openjdk
Copy link

openjdk bot commented Jun 19, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307569: Build with gcc8 is broken after JDK-8307301

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 5fc07b5: 8305815: Update Libpng to 1.6.39
  • 9dd23ff: 8292315: Tests should not rely on specific JAR file names (hotspot)
  • f21f9a4: 8292316: Tests should not rely on specific JAR file names (jpackage)
  • 01369a6: 8285756: clean up use of bad arguments for @clean in langtools tests
  • 4bbead6: 8286620: Create regression test for verifying setMargin() of JRadioButton
  • 24b31cd: 8280396: G1: Full gc mark stack draining should prefer to make work available to other threads
  • 1258a71: 8281507: Two javac tests have bad jtreg @clean tags
  • 75a911c: 8209398: sun/security/pkcs11/KeyStore/SecretKeysBasic.sh failed with "PKCS11Exception: CKR_ATTRIBUTE_SENSITIVE"
  • dd9cefd: 8267341: macos attempt_reserve_memory_at(arg1, arg2, true) failure
  • 7f2344b: 8278456: Define jtreg jdk_desktop test group time-based sub-tasks for use by headful testing.

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 19, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Jun 23, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jun 23, 2023

Going to push as commit c8e9c91.
Since your change was applied there have been 37 commits pushed to the master branch:

  • 09fdf1d: 8292182: [TESTLIB] Enhance JAXPPolicyManager to setup required permissions for jtreg version 7 jar
  • 031a5ed: 8306435: Juggle04/TestDescription.java should be a booleanArr test and not a byteArr one
  • ee6fc5a: 8304845: Update PCSC-Lite for Suse Linux to 1.9.9 and fix incomplete license wording
  • 37d943e: 8040793: vmTestbase/nsk/monitoring/stress/lowmem fails on calling isCollectionUsageThresholdExceeded()
  • 781df52: 8300659: Refactor TestMemoryAwareness to use WhiteBox api for host values
  • ab27843: 8283056: show abstract machine code in hs-err for all VM crashes
  • 9a49698: 8267188: gc/stringdedup/TestStringDeduplicationInterned.java fails with Shenandoah
  • 48d7af6: 8263044: jdk/jfr/jvm/TestDumpOnCrash.java timed out
  • 5ec9b86: 8274986: max code printed in hs-err logs should be configurable
  • 878cea2: 8252713: jtreg time out of CtrlASCII.java seems to hang the Xserver.
  • ... and 27 more: https://git.openjdk.org/jdk17u-dev/compare/91815351dfbf37b73a65c005adb6012dfc050501...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 23, 2023
@openjdk openjdk bot closed this Jun 23, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 23, 2023
@openjdk
Copy link

openjdk bot commented Jun 23, 2023

@GoeLin Pushed as commit c8e9c91.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8307569 branch June 23, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants