Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8310126: C1: Missing receiver null check in Reference::get intrinsic #1474

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Jun 20, 2023

Clean backport to fix JDK 11 regression in C1.

Additional testing:

  • New test fails before the patch, passes with it
  • Linux AArch64 fastdebug tier1 tier2 tier3

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8310126: C1: Missing receiver null check in Reference::get intrinsic (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1474/head:pull/1474
$ git checkout pull/1474

Update a local copy of the PR:
$ git checkout pull/1474
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1474/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1474

View PR using the GUI difftool:
$ git pr show -t 1474

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1474.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 20, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 02aaab12e331e5a4c249f1d281c4439e2e7c914f 8310126: C1: Missing receiver null check in Reference::get intrinsic Jun 20, 2023
@openjdk
Copy link

openjdk bot commented Jun 20, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 20, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310126: C1: Missing receiver null check in Reference::get intrinsic

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • fb1741c: 8309956: Shenandoah: Strengthen the mark word check in string dedup
  • 3773e0b: 8309228: Clarify EXPERIMENTAL flags comment in hotspot/share/runtime/globals.hpp
  • aa3b4e4: 8305236: Some LoadLoad barriers in the interpreter are unnecessary after JDK-8220051
  • bda6723: 8282665: [REDO] ByteBufferTest.java: replace endless recursion with RuntimeException in void ck(double x, double y)
  • 393aeaf: 8272586: emit abstract machine code in hs-err logs
  • d85a847: 8289688: jfr command hangs when it processes invalid file
  • 9780137: 8286481: Exception printed to stdout on Windows when storing transparent image in clipboard

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 20, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 20, 2023

Webrevs

@shipilev
Copy link
Member Author

Push approval is here. Testing is clean.

/integrate

@openjdk
Copy link

openjdk bot commented Jun 28, 2023

Going to push as commit 95b4ddc.
Since your change was applied there have been 36 commits pushed to the master branch:

  • 4fd0ee5: 8305425: Thread.isAlive0 doesn't need to call into the VM
  • 8204dfa: 8289238: Refactoring changes to PassFailJFrame Test Framework
  • d27e56e: 8305950: Have -XshowSettings option display tzdata version
  • 9b89523: 8298974: Add ftcolor.c to imported freetype sources
  • 5021a07: 8287227: Shenandoah: A couple of virtual thread tests failed with iu mode even without Loom enabled.
  • b8a65e0: 8277654: Shenandoah: Don't produce new memory state in C2 LRB runtime call
  • 832707b: 8229147: Linux os::create_thread() overcounts guardpage size with newer glibc (>=2.27)
  • dfe3555: 8303215: Make thread stacks not use huge pages
  • 52fb263: 8306428: RunThese30M.java crashed with assert(early->flag() == current->flag() || early->flag() == mtNone)
  • 00b8f5d: 8308643: Incorrect value of 'used' jvmstat counter
  • ... and 26 more: https://git.openjdk.org/jdk17u-dev/compare/0368ae919705ba85638ea0dc9ab8fb7db8d62384...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 28, 2023
@openjdk openjdk bot closed this Jun 28, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 28, 2023
@openjdk
Copy link

openjdk bot commented Jun 28, 2023

@shipilev Pushed as commit 95b4ddc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8310126-c1-reference-get branch July 20, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant