Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265261: java/nio/file/Files/InterruptCopy.java fails with java.lang.RuntimeException: Copy was not interrupted #148

Closed
wants to merge 1 commit into from

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Feb 8, 2022

A clean and test only backport for parity with Oracle 17.0.4.

Test:

  • Test passed on Linux x86_64.
  • Test passed on Windows 10.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8265261: java/nio/file/Files/InterruptCopy.java fails with java.lang.RuntimeException: Copy was not interrupted

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/148/head:pull/148
$ git checkout pull/148

Update a local copy of the PR:
$ git checkout pull/148
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/148/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 148

View PR using the GUI difftool:
$ git pr show -t 148

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/148.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 8, 2022

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport aaedac635a0a7ca1f73dcf85336230cc537fcdf2 8265261: java/nio/file/Files/InterruptCopy.java fails with java.lang.RuntimeException: Copy was not interrupted Feb 8, 2022
@openjdk
Copy link

openjdk bot commented Feb 8, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 8, 2022

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265261: java/nio/file/Files/InterruptCopy.java fails with java.lang.RuntimeException: Copy was not interrupted

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • f391654: 8275330: C2: assert(n->is_Root() || n->is_Region() || n->is_Phi() || n->is_MachMerge() || def_block->dominates(block)) failed: uses must be dominated by definitions

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 8, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 8, 2022

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 9, 2022

@zhengyu123 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@zhengyu123
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 21, 2022

Going to push as commit f2329d5.
Since your change was applied there have been 112 commits pushed to the master branch:

  • 049b1ba: 8280401: [sspi] gss_accept_sec_context leaves output_token uninitialized
  • 7650afa: 8279227: Access Bridge: Wrong frame position and hit test result on HiDPI display
  • a605a30: 8277087: ZipException: zip END header not found at ZipFile#Source.findEND
  • cbe4973: 8278851: Correct signer logic for jars signed with multiple digestalgs
  • 32148d2: 8276796: gc/TestSystemGC.java large pages subtest fails with ZGC
  • fbe05ec: 8280476: [macOS] : hotspot arm64 bug exposed by latest clang
  • 90126f8: 8214733: runtime/8176717/TestInheritFD.java timed out
  • 00f201d: 8279437: [JVMCI] exception in HotSpotJVMCIRuntime.translate can exit the VM
  • 2acca94: 8278186: org.jcp.xml.dsig.internal.dom.Utils.parseIdFromSameDocumentURI throws StringIndexOutOfBoundsException when calling substring method
  • 40dce20: 8277422: tools/jar/JarEntryTime.java fails with modified time mismatch
  • ... and 102 more: https://git.openjdk.java.net/jdk17u-dev/compare/5159ffd487d858f33eb50f0bb8f2bfb28fcce5ae...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 21, 2022
@openjdk openjdk bot closed this Mar 21, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 21, 2022
@openjdk
Copy link

openjdk bot commented Mar 21, 2022

@zhengyu123 Pushed as commit f2329d5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant