Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8309613: [Windows] hs_err files sometimes miss information about the code containing the error #1482

Closed

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Jun 21, 2023

Backport of JDK-8309613. Requires manual integration, but it's pretty straightforward.

Manually tested on Windows like in the upstream PR (without hsdis provided):

---------------  T H R E A D  ---------------

Current thread (0x000000c5550feee0):  JavaThread "main" [_thread_in_Java, id=628356, stack(0x000000c5547a0000,0x000000c5548a000
0)]

Stack: [0x000000c5547a0000,0x000000c5548a0000]
Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code)
V  [jvm.dll+0x64c869]  os::platform_print_native_stack+0xd9  (os_windows_x86.cpp:235)
V  [jvm.dll+0x7f6467]  VMError::report+0xc67  (vmerror.cpp:852)
V  [jvm.dll+0x7f7e1e]  VMError::report_and_die+0x79e  (vmerror.cpp:1710)
V  [jvm.dll+0x236ce7]  report_fatal+0x97  (debug.cpp:302)
V  [jvm.dll+0x586086]  MacroAssembler::debug64+0x96  (macroassembler_x86.cpp:865)
C  0x000000c564791247

The last pc belongs to nmethod (printed below).

Compiled method (c2)     498   32       4       java.lang.Object::<init> (1 bytes)
 total in heap  [0x000000c564791090,0x000000c5647912b0] = 544
 relocation     [0x000000c5647911e8,0x000000c564791200] = 24
 main code      [0x000000c564791200,0x000000c564791260] = 96
 stub code      [0x000000c564791260,0x000000c564791278] = 24
 metadata       [0x000000c564791278,0x000000c564791280] = 8
 scopes data    [0x000000c564791280,0x000000c564791288] = 8
 scopes pcs     [0x000000c564791288,0x000000c5647912a8] = 32
 dependencies   [0x000000c5647912a8,0x000000c5647912b0] = 8

[Constant Pool (empty)]

[MachCode]
[Entry Point]
  # {method} {0x0000000800443ff8} '<init>' '()V' in 'java/lang/Object'
  #           [sp+0x20]  (sp of caller)
  0x000000c564791200: 448b 5208 | 49bb 0000 | 0000 0800 | 0000 4d03 | d349 3bc2 

  0x000000c564791214: ;   {runtime_call ic_miss_stub}
  0x000000c564791214: 0f85 66fe | 8fff 6690 | 0f1f 4000 
[Verified Entry Point]
  0x000000c564791220: 4881 ec18 | 0000 0048 | 896c 2410 

  0x000000c56479122c: ;   {external_word}
  0x000000c56479122c: 48b9 1806 | b598 fa7f | 0000 4883 

  0x000000c564791238: ;   {runtime_call MacroAssembler::debug64}
  0x000000c564791238: e4f0 49ba | f05f 7598 | fa7f 0000 | 41ff d2f4 | f4f4 f4f4 | f4f4 f4f4 | f4f4 f4f4 | f4f4 f4f4 
  0x000000c564791258: f4f4 f4f4 | f4f4 f4f4 
[Exception Handler]
  0x000000c564791260: ;   {no_reloc}
  0x000000c564791260: e99b 5d91 | ffe8 0000 | 0000 4883 

  0x000000c56479126c: ;   {runtime_call DeoptimizationBlob}
  0x000000c56479126c: 2c24 05e9 | 2c5a 90ff | f4f4 f4f4 
[/MachCode]

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8309613: [Windows] hs_err files sometimes miss information about the code containing the error (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1482/head:pull/1482
$ git checkout pull/1482

Update a local copy of the PR:
$ git checkout pull/1482
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1482/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1482

View PR using the GUI difftool:
$ git pr show -t 1482

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1482.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 21, 2023

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport bd79db3930f192f6742e29a63a6d1c3bc3dd3385 8309613: [Windows] hs_err files sometimes miss information about the code containing the error Jun 21, 2023
@openjdk
Copy link

openjdk bot commented Jun 21, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 21, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 21, 2023

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Jun 21, 2023

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309613: [Windows] hs_err files sometimes miss information about the code containing the error

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • 7c97df2: 8309862: Unsafe list operations in JfrStringPool
  • 19acd07: 8307301: Update HarfBuzz to 7.2.0
  • f8e0f6e: 8307604: gcc12 based Alpine build broken build after JDK-8307301
  • c8e9c91: 8307569: Build with gcc8 is broken after JDK-8307301
  • 09fdf1d: 8292182: [TESTLIB] Enhance JAXPPolicyManager to setup required permissions for jtreg version 7 jar
  • 031a5ed: 8306435: Juggle04/TestDescription.java should be a booleanArr test and not a byteArr one
  • ee6fc5a: 8304845: Update PCSC-Lite for Suse Linux to 1.9.9 and fix incomplete license wording
  • 37d943e: 8040793: vmTestbase/nsk/monitoring/stress/lowmem fails on calling isCollectionUsageThresholdExceeded()
  • 781df52: 8300659: Refactor TestMemoryAwareness to use WhiteBox api for host values
  • ab27843: 8283056: show abstract machine code in hs-err for all VM crashes
  • ... and 1 more: https://git.openjdk.org/jdk17u-dev/compare/48d7af6d7201a80143998dc54862acd4e4142f58...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 21, 2023
@TheRealMDoerr
Copy link
Contributor Author

Thanks for the review!

@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 23, 2023

Going to push as commit 8dae82c.
Since your change was applied there have been 12 commits pushed to the master branch:

  • bd0e479: 8153837: AArch64: Handle special cases for MaxINode & MinINode
  • 7c97df2: 8309862: Unsafe list operations in JfrStringPool
  • 19acd07: 8307301: Update HarfBuzz to 7.2.0
  • f8e0f6e: 8307604: gcc12 based Alpine build broken build after JDK-8307301
  • c8e9c91: 8307569: Build with gcc8 is broken after JDK-8307301
  • 09fdf1d: 8292182: [TESTLIB] Enhance JAXPPolicyManager to setup required permissions for jtreg version 7 jar
  • 031a5ed: 8306435: Juggle04/TestDescription.java should be a booleanArr test and not a byteArr one
  • ee6fc5a: 8304845: Update PCSC-Lite for Suse Linux to 1.9.9 and fix incomplete license wording
  • 37d943e: 8040793: vmTestbase/nsk/monitoring/stress/lowmem fails on calling isCollectionUsageThresholdExceeded()
  • 781df52: 8300659: Refactor TestMemoryAwareness to use WhiteBox api for host values
  • ... and 2 more: https://git.openjdk.org/jdk17u-dev/compare/48d7af6d7201a80143998dc54862acd4e4142f58...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 23, 2023
@openjdk openjdk bot closed this Jun 23, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 23, 2023
@openjdk
Copy link

openjdk bot commented Jun 23, 2023

@TheRealMDoerr Pushed as commit 8dae82c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr TheRealMDoerr deleted the 8309613_Windows_hs_err branch June 23, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants