Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8153837: AArch64: Handle special cases for MaxINode & MinINode #1483

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Jun 21, 2023

Backport of JDK-8153837.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8153837: AArch64: Handle special cases for MaxINode & MinINode (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1483/head:pull/1483
$ git checkout pull/1483

Update a local copy of the PR:
$ git checkout pull/1483
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1483/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1483

View PR using the GUI difftool:
$ git pr show -t 1483

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1483.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 21, 2023

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b3684f4bacd8310eea75ebf4ccc70397328d5e86 8153837: AArch64: Handle special cases for MaxINode & MinINode Jun 21, 2023
@openjdk
Copy link

openjdk bot commented Jun 21, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 21, 2023

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8153837: AArch64: Handle special cases for MaxINode & MinINode

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 21, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 21, 2023

Webrevs

@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 23, 2023

Going to push as commit bd0e479.
Since your change was applied there have been 11 commits pushed to the master branch:

  • 7c97df2: 8309862: Unsafe list operations in JfrStringPool
  • 19acd07: 8307301: Update HarfBuzz to 7.2.0
  • f8e0f6e: 8307604: gcc12 based Alpine build broken build after JDK-8307301
  • c8e9c91: 8307569: Build with gcc8 is broken after JDK-8307301
  • 09fdf1d: 8292182: [TESTLIB] Enhance JAXPPolicyManager to setup required permissions for jtreg version 7 jar
  • 031a5ed: 8306435: Juggle04/TestDescription.java should be a booleanArr test and not a byteArr one
  • ee6fc5a: 8304845: Update PCSC-Lite for Suse Linux to 1.9.9 and fix incomplete license wording
  • 37d943e: 8040793: vmTestbase/nsk/monitoring/stress/lowmem fails on calling isCollectionUsageThresholdExceeded()
  • 781df52: 8300659: Refactor TestMemoryAwareness to use WhiteBox api for host values
  • ab27843: 8283056: show abstract machine code in hs-err for all VM crashes
  • ... and 1 more: https://git.openjdk.org/jdk17u-dev/compare/48d7af6d7201a80143998dc54862acd4e4142f58...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 23, 2023
@openjdk openjdk bot closed this Jun 23, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 23, 2023
@openjdk
Copy link

openjdk bot commented Jun 23, 2023

@TheRealMDoerr Pushed as commit bd0e479.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant