Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8229147: Linux os::create_thread() overcounts guardpage size with newer glibc (>=2.27) #1489

Closed

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Jun 22, 2023

Backport of JDK-8229147. It's basically clean. There are only differences in the removed code and comments:

< -GetMinStack _get_minstack_func = nullptr;
---
> -GetMinStack _get_minstack_func = NULL;
< -                       _get_minstack_func == nullptr ? "failed" : "succeeded");
---
> -                       _get_minstack_func == NULL ? "failed" : "succeeded");
< -  // In glibc versions prior to 2.27 the guard size mechanism
---
> -  // In glibc versions prior to 2.7 the guard size mechanism
< -  // stack_size by the size of the guard pages to mimic proper
---
> -  // stack_size by the size of the guard pages to mimick proper

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8229147: Linux os::create_thread() overcounts guardpage size with newer glibc (>=2.27) (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1489/head:pull/1489
$ git checkout pull/1489

Update a local copy of the PR:
$ git checkout pull/1489
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1489/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1489

View PR using the GUI difftool:
$ git pr show -t 1489

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1489.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 22, 2023

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9ebcda2165c42e3f7b82a9ae8074badb69c0d270 8229147: Linux os::create_thread() overcounts guardpage size with newer glibc (>=2.27) Jun 22, 2023
@openjdk
Copy link

openjdk bot commented Jun 22, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 22, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 22, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 23, 2023

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8229147: Linux os::create_thread() overcounts guardpage size with newer glibc (>=2.27)

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • bd0e479: 8153837: AArch64: Handle special cases for MaxINode & MinINode
  • 7c97df2: 8309862: Unsafe list operations in JfrStringPool
  • 19acd07: 8307301: Update HarfBuzz to 7.2.0
  • f8e0f6e: 8307604: gcc12 based Alpine build broken build after JDK-8307301
  • c8e9c91: 8307569: Build with gcc8 is broken after JDK-8307301
  • 09fdf1d: 8292182: [TESTLIB] Enhance JAXPPolicyManager to setup required permissions for jtreg version 7 jar

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 23, 2023
@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 23, 2023

Going to push as commit 832707b.
Since your change was applied there have been 11 commits pushed to the master branch:

  • dfe3555: 8303215: Make thread stacks not use huge pages
  • 52fb263: 8306428: RunThese30M.java crashed with assert(early->flag() == current->flag() || early->flag() == mtNone)
  • 00b8f5d: 8308643: Incorrect value of 'used' jvmstat counter
  • e0c9643: 8306281: function isWsl() returns false on WSL2
  • 8dae82c: 8309613: [Windows] hs_err files sometimes miss information about the code containing the error
  • bd0e479: 8153837: AArch64: Handle special cases for MaxINode & MinINode
  • 7c97df2: 8309862: Unsafe list operations in JfrStringPool
  • 19acd07: 8307301: Update HarfBuzz to 7.2.0
  • f8e0f6e: 8307604: gcc12 based Alpine build broken build after JDK-8307301
  • c8e9c91: 8307569: Build with gcc8 is broken after JDK-8307301
  • ... and 1 more: https://git.openjdk.org/jdk17u-dev/compare/031a5edebd83d15f4b0a6f09f9554c65790bc166...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 23, 2023
@openjdk openjdk bot closed this Jun 23, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 23, 2023
@openjdk
Copy link

openjdk bot commented Jun 23, 2023

@TheRealMDoerr Pushed as commit 832707b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr TheRealMDoerr deleted the 8229147_glibc_guardpage branch June 23, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants