Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276177: nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption failed with "assert(def_ik->is_being_redefined()) failed: should be being redefined to get here" #15

Closed

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Dec 20, 2021

A clean backport for parity with Oracle 17.0.3.

Test:

  • nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption now passed.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8276177: nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption failed with "assert(def_ik->is_being_redefined()) failed: should be being redefined to get here"

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/15/head:pull/15
$ git checkout pull/15

Update a local copy of the PR:
$ git checkout pull/15
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/15/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15

View PR using the GUI difftool:
$ git pr show -t 15

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/15.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 20, 2021

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a907b2b144f2af27392eb7c2f9656fbb1a759618 8276177: nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption failed with "assert(def_ik->is_being_redefined()) failed: should be being redefined to get here" Dec 20, 2021
@openjdk
Copy link

openjdk bot commented Dec 20, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Dec 20, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 20, 2021

Webrevs

GoeLin
GoeLin approved these changes Dec 21, 2021
Copy link
Member

@GoeLin GoeLin left a comment

Hi,
the backport is not really clean. The ProblemList patch was omitted because the Test was not ProblemListed in 17.
But the changes to code are clean.

@openjdk
Copy link

openjdk bot commented Dec 21, 2021

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276177: nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption failed with "assert(def_ik->is_being_redefined()) failed: should be being redefined to get here"

Reviewed-by: goetz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 21, 2021
@GoeLin
Copy link
Member

GoeLin commented Dec 21, 2021

Zhengyu, if you mention this trivial change to the ProblemList in the comment above, you can use the /clean command. This is a cosmetic change as mentioned on https://wiki.openjdk.java.net/display/JDKUpdates/JDK+17u .
Please configure testing of jdk17u-dev in your Git repo.

@zhengyu123
Copy link
Contributor Author

zhengyu123 commented Dec 22, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Dec 22, 2021

Going to push as commit 93234a4.
Since your change was applied there have been 10 commits pushed to the master branch:

  • c9ebb93: 8275650: Problemlist java/io/File/createTempFile/SpecialTempFile.java for Windows 11
  • 2cac565: 8273704: DrawStringWithInfiniteXform.java failed : drawString with InfiniteXform transform takes long time
  • 83f1749: 8273162: AbstractSplittableWithBrineGenerator does not create a random salt
  • 515d412: 8273351: bad tag in jdk.random module-info.java
  • 311bb85: 8247980: Exclusive execution of java/util/stream tests slows down tier1
  • 79d97c4: 8272327: Shenandoah: Avoid enqueuing duplicate string candidates
  • 13d3046: 8278115: gc/stress/gclocker/TestGCLockerWithSerial.java has duplicate -Xmx
  • 6634879: 8278116: runtime/modules/LoadUnloadModuleStress.java has duplicate -Xmx
  • 4b3a9e3: 8277992: Add fast jdk_svc subtests to jdk:tier3
  • cc4a0b1: 8278016: Add compiler tests to tier{2,3}

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 22, 2021
@openjdk openjdk bot closed this Dec 22, 2021
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 22, 2021
@openjdk
Copy link

openjdk bot commented Dec 22, 2021

@zhengyu123 Pushed as commit 93234a4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants