Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8308152: PropertyDescriptor should work with overridden generic getter method #1501

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Jun 26, 2023

Hi all,

This pull request contains a backport of commit 73dd03cc from the openjdk/jdk repository.

The commit being backported was authored by Sergey Bylokhov on 8 Jun 2023 and was reviewed by Alexander Zvegintsev.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8308152: PropertyDescriptor should work with overridden generic getter method (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1501/head:pull/1501
$ git checkout pull/1501

Update a local copy of the PR:
$ git checkout pull/1501
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1501/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1501

View PR using the GUI difftool:
$ git pr show -t 1501

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1501.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 26, 2023

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 73dd03cc5afa6d1e01a92d0027dcb82af27a48af 8308152: PropertyDescriptor should work with overridden generic getter method Jun 26, 2023
@openjdk
Copy link

openjdk bot commented Jun 26, 2023

This backport pull request has now been updated with issue from the original commit.

@mrserb mrserb marked this pull request as ready for review June 27, 2023 16:02
@openjdk
Copy link

openjdk bot commented Jun 27, 2023

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308152: PropertyDescriptor should work with overridden generic getter method

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 27, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 27, 2023

Webrevs

@mrserb
Copy link
Member Author

mrserb commented Jun 28, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jun 28, 2023

Going to push as commit 3d53b27.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 95b4ddc: 8310126: C1: Missing receiver null check in Reference::get intrinsic
  • 4fd0ee5: 8305425: Thread.isAlive0 doesn't need to call into the VM
  • 8204dfa: 8289238: Refactoring changes to PassFailJFrame Test Framework
  • d27e56e: 8305950: Have -XshowSettings option display tzdata version

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 28, 2023
@openjdk openjdk bot closed this Jun 28, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 28, 2023
@openjdk
Copy link

openjdk bot commented Jun 28, 2023

@mrserb Pushed as commit 3d53b27.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant