Skip to content

8305950: Have -XshowSettings option display tzdata version #1502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Jun 27, 2023

Backport of JDK-8305950. Applies cleanly except Copyright year update.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8305950: Have -XshowSettings option display tzdata version (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1502/head:pull/1502
$ git checkout pull/1502

Update a local copy of the PR:
$ git checkout pull/1502
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1502/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1502

View PR using the GUI difftool:
$ git pr show -t 1502

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1502.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 27, 2023

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 07f55c5ea280032b72247049223f676424aa44c0 8305950: Have -XshowSettings option display tzdata version Jun 27, 2023
@openjdk
Copy link

openjdk bot commented Jun 27, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 27, 2023
@TheRealMDoerr
Copy link
Contributor Author

/clean

@openjdk openjdk bot added the clean label Jun 27, 2023
@openjdk
Copy link

openjdk bot commented Jun 27, 2023

@TheRealMDoerr This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Jun 27, 2023

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8305950: Have -XshowSettings option display tzdata version

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 27, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 27, 2023

Webrevs

@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 28, 2023

Going to push as commit d27e56e.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 28, 2023
@openjdk openjdk bot closed this Jun 28, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 28, 2023
@openjdk
Copy link

openjdk bot commented Jun 28, 2023

@TheRealMDoerr Pushed as commit d27e56e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr TheRealMDoerr deleted the 8305950_XshowSettings branch June 28, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant