Skip to content

Conversation

@chadrako
Copy link
Contributor

@chadrako chadrako commented Jun 27, 2023

Backport for JDK-8306812
Adds several AWT Miscellaneous tests
tier1 tested with GHA
tier2 tested on linux


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8306812: Open source several AWT Miscellaneous tests (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1503/head:pull/1503
$ git checkout pull/1503

Update a local copy of the PR:
$ git checkout pull/1503
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1503/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1503

View PR using the GUI difftool:
$ git pr show -t 1503

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1503.diff

Webrev

Link to Webrev Comment

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Jun 27, 2023
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 27, 2023

Hi @chadrako, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user chadrako" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk openjdk bot changed the title Backport c494770ca0662d95ed35f9244a7a9e012aab61a7 8306812: Open source several AWT Miscellaneous tests Jun 27, 2023
@openjdk
Copy link

openjdk bot commented Jun 27, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jun 27, 2023
@chadrako
Copy link
Contributor Author

/covered

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Jun 27, 2023
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 27, 2023

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@phohensee
Copy link
Member

I can verify that Chad is an Amazon employee and thus covered under the OCA.

@bridgekeeper bridgekeeper bot removed oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status labels Jul 2, 2023
@openjdk
Copy link

openjdk bot commented Jul 2, 2023

@chadrako This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306812: Open source several AWT Miscellaneous tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 59 new commits pushed to the master branch:

  • e8e87c4: 8289547: Update javax/swing/Popup/TaskbarPositionTest.java
  • b8cf161: 8307078: Opensource and clean up five more AWT Focus related tests
  • 8d49a8a: 8306638: Open source some AWT tests related to datatransfer and Toolkit
  • b7c1456: 8276696: ParallelObjectIterator freed at the wrong time in VM_HeapDumper
  • e28a5ea: 8280885: Shenandoah: Some tests failed with "EA: missing allocation reference path"
  • 90345a4: 8308766: TLAB initialization may cause div by zero
  • 4d261ef: 8300693: Lower the compile threshold and reduce the iterations of warmup loop in VarHandles tests
  • cf868a5: 8171221: Remove -XX:+CheckMemoryInitialization
  • 42caa28: 8300405: Screen capture for test JFileChooserSetLocationTest.java, failure case
  • ce054c9: 8284760: Correct type/array element offset in LibraryCallKit::get_state_from_digest_object()
  • ... and 49 more: https://git.openjdk.org/jdk17u-dev/compare/9a496989733c6af7b012638a9de67a9904eca1e1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 2, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 2, 2023

Webrevs

@chadrako
Copy link
Contributor Author

chadrako commented Jul 5, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 5, 2023
@openjdk
Copy link

openjdk bot commented Jul 5, 2023

@chadrako
Your change (at version e441cdf) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 5, 2023

Going to push as commit b3cf45a.
Since your change was applied there have been 59 commits pushed to the master branch:

  • e8e87c4: 8289547: Update javax/swing/Popup/TaskbarPositionTest.java
  • b8cf161: 8307078: Opensource and clean up five more AWT Focus related tests
  • 8d49a8a: 8306638: Open source some AWT tests related to datatransfer and Toolkit
  • b7c1456: 8276696: ParallelObjectIterator freed at the wrong time in VM_HeapDumper
  • e28a5ea: 8280885: Shenandoah: Some tests failed with "EA: missing allocation reference path"
  • 90345a4: 8308766: TLAB initialization may cause div by zero
  • 4d261ef: 8300693: Lower the compile threshold and reduce the iterations of warmup loop in VarHandles tests
  • cf868a5: 8171221: Remove -XX:+CheckMemoryInitialization
  • 42caa28: 8300405: Screen capture for test JFileChooserSetLocationTest.java, failure case
  • ce054c9: 8284760: Correct type/array element offset in LibraryCallKit::get_state_from_digest_object()
  • ... and 49 more: https://git.openjdk.org/jdk17u-dev/compare/9a496989733c6af7b012638a9de67a9904eca1e1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 5, 2023
@openjdk openjdk bot closed this Jul 5, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 5, 2023
@openjdk
Copy link

openjdk bot commented Jul 5, 2023

@phohensee @chadrako Pushed as commit b3cf45a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants