Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8290469: Add new positioning options to PassFailJFrame test framework #1506

Closed

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Jun 28, 2023

Backport of JDK-8290469. The tests ModalDialogTest.java, PrintAllPagesTest.java and HtmlScriptTagParserTest.java are not in 17u. Skipped. The rest applies cleanly. Tested manually.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8290469: Add new positioning options to PassFailJFrame test framework (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1506/head:pull/1506
$ git checkout pull/1506

Update a local copy of the PR:
$ git checkout pull/1506
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1506/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1506

View PR using the GUI difftool:
$ git pr show -t 1506

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1506.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 28, 2023

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 568be58e8521e5e87baca1872ba8cc1941607bb7 8290469: Add new positioning options to PassFailJFrame test framework Jun 28, 2023
@openjdk
Copy link

openjdk bot commented Jun 28, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 28, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 28, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 30, 2023

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290469: Add new positioning options to PassFailJFrame test framework

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 99c7ade: 8301074: Replace NULL with nullptr in share/opto/
  • 1472676: 8269466: Factor out the common code for initializing and starting internal VM JavaThreads
  • c5649ac: 8297887: Update Siphash
  • c3b8ea3: 8297681: Unnecessary color conversion during 4BYTE_ABGR_PRE to INT_ARGB_PRE blit
  • 4dd316b: 8307156: native_thread not protected by TLH
  • 295cf44: 8290464: Optimize ResourceArea zapping on ResourceMark release
  • b8a0a22: 8295812: Skip the "half float" support in LittleCMS during the build
  • 3d53b27: 8308152: PropertyDescriptor should work with overridden generic getter method

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 30, 2023
@TheRealMDoerr
Copy link
Contributor Author

Thanks for the review!
/integrate

@openjdk
Copy link

openjdk bot commented Jun 30, 2023

Going to push as commit 62140e2.
Since your change was applied there have been 14 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 30, 2023
@openjdk openjdk bot closed this Jun 30, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 30, 2023
@openjdk
Copy link

openjdk bot commented Jun 30, 2023

@TheRealMDoerr Pushed as commit 62140e2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr TheRealMDoerr deleted the 8290469_PassFailJFrame branch June 30, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants