Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8288497: add support for JavaThread::is_oop_safe() #1514

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Jun 29, 2023

Clean backport on the way to fix JDK-8288139. Requires follow-ups as dependent PRs.

Additional testing:

  • Linux AArch64 fastdebug tier1 (as part of whole batch of PRs)
  • Linux AArch64 fastdebug tier2 (as part of whole batch of PRs)
  • Linux AArch64 fastdebug tier3 (as part of whole batch of PRs)

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8288497: add support for JavaThread::is_oop_safe() (Sub-task - P2)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1514/head:pull/1514
$ git checkout pull/1514

Update a local copy of the PR:
$ git checkout pull/1514
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1514/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1514

View PR using the GUI difftool:
$ git pr show -t 1514

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1514.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 29, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e26d3b3c01a06f250344d0afdaa9fadd1fdae33b 8288497: add support for JavaThread::is_oop_safe() Jun 29, 2023
@openjdk
Copy link

openjdk bot commented Jun 29, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 29, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288497: add support for JavaThread::is_oop_safe()

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • a563c45: 8306682: Open source a few more AWT Choice tests
  • a424cdd: 8306484: Open source several AWT Choice jtreg tests
  • 7f8e1de: 8306430: Open source some AWT tests related to TextComponent and Toolkit
  • 2d26f38: 8306372: Open source AWT CardLayout and Checkbox tests
  • 4013216: 8306134: Open source some AWT tests relating to Button and a few other classes
  • 0b0c61e: 8289077: Add manual tests to open
  • 99c7ade: 8301074: Replace NULL with nullptr in share/opto/
  • 1472676: 8269466: Factor out the common code for initializing and starting internal VM JavaThreads
  • c5649ac: 8297887: Update Siphash
  • c3b8ea3: 8297681: Unnecessary color conversion during 4BYTE_ABGR_PRE to INT_ARGB_PRE blit

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 29, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 29, 2023

Webrevs

@shipilev shipilev force-pushed the JDK-8288497-thread-is-oop-safe branch from 842963d to b84ae04 Compare June 29, 2023 17:13
@openjdk
Copy link

openjdk bot commented Jun 29, 2023

@shipilev Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 28, 2023

@shipilev This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 25, 2023

@shipilev This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review
1 participant