Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8288139: JavaThread touches oop after GC barrier is detached #1515

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Jun 29, 2023

Unclean backport to avoid a JVM crash. The source for uncleanliness is the absent JavaThread::cast, which I replaced back to ->as_Java_thread().

Additional testing:

  • Linux AArch64 fastdebug tier1 (as part of whole batch of PRs)
  • Linux AArch64 fastdebug tier2 (as part of whole batch of PRs)
  • Linux AArch64 fastdebug tier3 (as part of whole batch of PRs)

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Integration blocker

 ⚠️ Dependency #1514 must be integrated first

Issue

  • JDK-8288139: JavaThread touches oop after GC barrier is detached (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1515/head:pull/1515
$ git checkout pull/1515

Update a local copy of the PR:
$ git checkout pull/1515
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1515/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1515

View PR using the GUI difftool:
$ git pr show -t 1515

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1515.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 29, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into pr/1514 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a1449886004b2f0a70f1413bb19ce3ba5c914fdf 8288139: JavaThread touches oop after GC barrier is detached Jun 29, 2023
@openjdk
Copy link

openjdk bot commented Jun 29, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 29, 2023
@shipilev shipilev force-pushed the JDK-8288139-thread-touch-oops branch from 504ec0d to 890c814 Compare June 29, 2023 17:13
@mlbridge
Copy link

mlbridge bot commented Jun 29, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 29, 2023

@shipilev Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Do you plan to also backport JDK-8289091?

@shipilev
Copy link
Member Author

Lgtm. Do you plan to also backport JDK-8289091?

Right. More bugtail, ugh. I need to take a look at that one before continuing.

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 28, 2023

@shipilev This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 25, 2023

@shipilev This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
2 participants