Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268582: javadoc throws NPE with --ignore-source-errors option #152

Closed
wants to merge 1 commit into from

Conversation

apavlyutkin
Copy link
Contributor

@apavlyutkin apavlyutkin commented Feb 9, 2022

I'd like to backport JDK-8268582 to jdk17u-dev

The patch fixes javadoc NPE when using the --ignore-source-errors option with an non-existing type.

Original patch applied cleanly

Verification: javadoc --ignore-source-errors ./Test.java where Test.java has the following content

import invalid.example.OtherClass;

public class Test<T> extends OtherClass<T> {

}

Regression: langtools_javadoc (20.04/amd64)


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8268582: javadoc throws NPE with --ignore-source-errors option

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/152/head:pull/152
$ git checkout pull/152

Update a local copy of the PR:
$ git checkout pull/152
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/152/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 152

View PR using the GUI difftool:
$ git pr show -t 152

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/152.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 9, 2022

👋 Welcome back apavlyutkin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0dfb3a705d2ad0ce4ac0f7dd18fb65d7ae735f16 8268582: javadoc throws NPE with --ignore-source-errors option Feb 9, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Feb 9, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 9, 2022

@apavlyutkin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268582: javadoc throws NPE with --ignore-source-errors option

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready rfr labels Feb 9, 2022
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 9, 2022

Webrevs

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 9, 2022

@apavlyutkin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@apavlyutkin apavlyutkin closed this Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean ready rfr
1 participant