Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8291444: GHA builds/tests won't run manually if disabled from automatic running #1525

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Jun 30, 2023

Hi all,

This pull request contains a backport of JDK-8291444, commit 5c0ff26f from the openjdk/jdk repository.

The commit being backported was authored by Christoph Langer on 2 Dec 2022 and was reviewed by Sergey Bylokhov, Erik Joelsson and Magnus Ihse Bursie.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8291444: GHA builds/tests won't run manually if disabled from automatic running (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1525/head:pull/1525
$ git checkout pull/1525

Update a local copy of the PR:
$ git checkout pull/1525
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1525/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1525

View PR using the GUI difftool:
$ git pr show -t 1525

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1525.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 30, 2023

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 5c0ff26f321ad36daa34bfc5b2d013b6c4a03810 8291444: GHA builds/tests won't run manually if disabled from automatic running Jun 30, 2023
@openjdk
Copy link

openjdk bot commented Jun 30, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 30, 2023

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8291444: GHA builds/tests won't run manually if disabled from automatic running

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 30, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 30, 2023

Webrevs

@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 4, 2023

Going to push as commit 17744ca.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 4c5dd40: 8308872: enhance logging and some exception in krb5/Config.java
  • 788d658: 8306135: Clean up and open source some AWT tests
  • 2f31b3f: 8306575: Clean up and open source four Dialog related tests
  • a72bdbf: 8303047: avoid NULL after 8301661

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 4, 2023
@openjdk openjdk bot closed this Jul 4, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 4, 2023
@openjdk
Copy link

openjdk bot commented Jul 4, 2023

@RealCLanger Pushed as commit 17744ca.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant