Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277417: C1 LIR instruction for load-klass #1528

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Jul 3, 2023

Clean backport to resolve the klass-ptr related kludges, match the relevant code to current state of mainline past JDK 18, and make life easier for downstreams like Lilliput JDK 17u.

There are two follow-ups, which are not critical, and which I would backport separately:

Additional testing:

  • Linux x86_64 fastdebug tier1 tier2 tier3
  • Linux AArch64 fastdebug tier1 tier2 tier3

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8277417: C1 LIR instruction for load-klass (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1528/head:pull/1528
$ git checkout pull/1528

Update a local copy of the PR:
$ git checkout pull/1528
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1528/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1528

View PR using the GUI difftool:
$ git pr show -t 1528

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1528.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 3, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 99e4bda303f2c71972a125d0ecaf4cf986c8614a 8277417: C1 LIR instruction for load-klass Jul 3, 2023
@openjdk
Copy link

openjdk bot commented Jul 3, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 3, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277417: C1 LIR instruction for load-klass

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 3, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 3, 2023

Webrevs

@shipilev
Copy link
Member Author

shipilev commented Jul 7, 2023

Push approval is here. Backport is clean. We have been running with this fix for a while now.

/integrate

@openjdk
Copy link

openjdk bot commented Jul 7, 2023

Going to push as commit d7a59f3.
Since your change was applied there have been 29 commits pushed to the master branch:

  • c2e274e: 8304725: AsyncGetCallTrace can cause SIGBUS on M1
  • 3b4df97: 6176679: Application freezes when copying an animated gif image to the system clipboard
  • 2bc77e3: 8299713: Test javax/swing/JTableHeader/6889007/bug6889007.java failed: Wrong type of cursor
  • 50399e3: 8304314: StackWalkTest.java fails after CODETOOLS-7903373
  • fc08b73: 8307348: Parallelize heap walk for ObjectCount(AfterGC) JFR event collection
  • 43f14e4: 8311249: Remove unused MemAllocator::obj_memory_range
  • 8a9162f: 8268852: AsyncLogWriter should not overide is_Named_thread()
  • 688a823: 8307299: Move more DnD tests to open
  • 93bfec2: 8307083: Open source some drag and drop tests 3
  • b3cf45a: 8306812: Open source several AWT Miscellaneous tests
  • ... and 19 more: https://git.openjdk.org/jdk17u-dev/compare/a72bdbfff53de6e27670c8c0a512e73756aa9405...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 7, 2023
@openjdk openjdk bot closed this Jul 7, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 7, 2023
@openjdk
Copy link

openjdk bot commented Jul 7, 2023

@shipilev Pushed as commit d7a59f3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8277417-c1-lir-load-klass branch July 20, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant