Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8307083: Open source some drag and drop tests 3 #1531

Closed
wants to merge 1 commit into from

Conversation

chadrako
Copy link
Contributor

@chadrako chadrako commented Jul 3, 2023

Backport for JDK-8307083
Open source some drag and drop tests
Clean test-only backport
tier1 tested with GHA
tier2 tested on linux


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8307083: Open source some drag and drop tests 3 (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1531/head:pull/1531
$ git checkout pull/1531

Update a local copy of the PR:
$ git checkout pull/1531
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1531/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1531

View PR using the GUI difftool:
$ git pr show -t 1531

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1531.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 3, 2023

👋 Welcome back chadrako! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1b154e4fd361103936f976db72e04b73aa7b1077 8307083: Open source some drag and drop tests 3 Jul 3, 2023
@openjdk
Copy link

openjdk bot commented Jul 3, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 3, 2023

@chadrako This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307083: Open source some drag and drop tests 3

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 59 new commits pushed to the master branch:

  • e8e87c4: 8289547: Update javax/swing/Popup/TaskbarPositionTest.java
  • b8cf161: 8307078: Opensource and clean up five more AWT Focus related tests
  • 8d49a8a: 8306638: Open source some AWT tests related to datatransfer and Toolkit
  • b7c1456: 8276696: ParallelObjectIterator freed at the wrong time in VM_HeapDumper
  • e28a5ea: 8280885: Shenandoah: Some tests failed with "EA: missing allocation reference path"
  • 90345a4: 8308766: TLAB initialization may cause div by zero
  • 4d261ef: 8300693: Lower the compile threshold and reduce the iterations of warmup loop in VarHandles tests
  • cf868a5: 8171221: Remove -XX:+CheckMemoryInitialization
  • 42caa28: 8300405: Screen capture for test JFileChooserSetLocationTest.java, failure case
  • ce054c9: 8284760: Correct type/array element offset in LibraryCallKit::get_state_from_digest_object()
  • ... and 49 more: https://git.openjdk.org/jdk17u-dev/compare/9a496989733c6af7b012638a9de67a9904eca1e1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 3, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 3, 2023

Webrevs

@chadrako
Copy link
Contributor Author

chadrako commented Jul 5, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 5, 2023
@openjdk
Copy link

openjdk bot commented Jul 5, 2023

@chadrako
Your change (at version 15b26e6) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 5, 2023

Going to push as commit 93bfec2.
Since your change was applied there have been 60 commits pushed to the master branch:

  • b3cf45a: 8306812: Open source several AWT Miscellaneous tests
  • e8e87c4: 8289547: Update javax/swing/Popup/TaskbarPositionTest.java
  • b8cf161: 8307078: Opensource and clean up five more AWT Focus related tests
  • 8d49a8a: 8306638: Open source some AWT tests related to datatransfer and Toolkit
  • b7c1456: 8276696: ParallelObjectIterator freed at the wrong time in VM_HeapDumper
  • e28a5ea: 8280885: Shenandoah: Some tests failed with "EA: missing allocation reference path"
  • 90345a4: 8308766: TLAB initialization may cause div by zero
  • 4d261ef: 8300693: Lower the compile threshold and reduce the iterations of warmup loop in VarHandles tests
  • cf868a5: 8171221: Remove -XX:+CheckMemoryInitialization
  • 42caa28: 8300405: Screen capture for test JFileChooserSetLocationTest.java, failure case
  • ... and 50 more: https://git.openjdk.org/jdk17u-dev/compare/9a496989733c6af7b012638a9de67a9904eca1e1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 5, 2023
@openjdk openjdk bot closed this Jul 5, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 5, 2023
@openjdk
Copy link

openjdk bot commented Jul 5, 2023

@phohensee @chadrako Pushed as commit 93bfec2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants