Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8307078: Opensource and clean up five more AWT Focus related tests #1539

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jul 4, 2023

I backport this for parity with 17.0.9-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8307078: Opensource and clean up five more AWT Focus related tests (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1539/head:pull/1539
$ git checkout pull/1539

Update a local copy of the PR:
$ git checkout pull/1539
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1539/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1539

View PR using the GUI difftool:
$ git pr show -t 1539

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1539.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 4, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6d6f726b74f7fcd3e7c37d50bd2476b3e921662b 8307078: Opensource and clean up five more AWT Focus related tests Jul 4, 2023
@openjdk
Copy link

openjdk bot commented Jul 4, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 4, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307078: Opensource and clean up five more AWT Focus related tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 4, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 4, 2023

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Jul 5, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jul 5, 2023

Going to push as commit b8cf161.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 8d49a8a: 8306638: Open source some AWT tests related to datatransfer and Toolkit
  • b7c1456: 8276696: ParallelObjectIterator freed at the wrong time in VM_HeapDumper
  • e28a5ea: 8280885: Shenandoah: Some tests failed with "EA: missing allocation reference path"
  • 90345a4: 8308766: TLAB initialization may cause div by zero
  • 4d261ef: 8300693: Lower the compile threshold and reduce the iterations of warmup loop in VarHandles tests
  • cf868a5: 8171221: Remove -XX:+CheckMemoryInitialization
  • 42caa28: 8300405: Screen capture for test JFileChooserSetLocationTest.java, failure case

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 5, 2023
@openjdk openjdk bot closed this Jul 5, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 5, 2023
@openjdk
Copy link

openjdk bot commented Jul 5, 2023

@GoeLin Pushed as commit b8cf161.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant