8272541: Incorrect overflow test in Toom-Cook branch of BigInteger multiplication

[gnu-andrew]

Clean backport. As @shipilev notes on the bug, the original code (JDK-8200659) was backported to all active branches in the January 2019 security update, so we should update the test everywhere as well.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8272541: Incorrect overflow test in Toom-Cook branch of BigInteger multiplication

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/154/head:pull/154
$ git checkout pull/154

Update a local copy of the PR:
$ git checkout pull/154
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/154/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 154

View PR using the GUI difftool:
$ git pr show -t 154

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/154.diff

[bridgekeeper]

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@gnu-andrew This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272541: Incorrect overflow test in Toom-Cook branch of BigInteger multiplication

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (c2d17f1f)

[gnu-andrew]

Failed test gc/stringdedup/TestStringDeduplicationAgeThreshold.java#id1 seems unrelated to this change.

[gnu-andrew]

/integrate

[openjdk]

Going to push as commit 8207e69.
Since your change was applied there have been 5 commits pushed to the master branch:

• ec1733d: 8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10
• 6cee018: 8272600: (test) Use native "sleep" in Basic.java
• 87010e7: 8271199: Mutual TLS handshake fails signing client certificate with custom sensitive PKCS11 key
• 2965051: 8277299: STACK_OVERFLOW in Java_sun_awt_shell_Win32ShellFolder2_getIconBits
• a5d00fb: 8281061: [s390] JFR runs into assertions while validating interpreter frames

Your commit was automatically rebased without conflicts.

[openjdk]

@gnu-andrew Pushed as commit 8207e69.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.