Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268852: AsyncLogWriter should not overide is_Named_thread() #1544

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Jul 5, 2023

Clean backport to improve async logging. We have been running with this patch for quite a while, and there were no problems detected with it.

Additional testing:

  • GHA tests

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8268852: AsyncLogWriter should not overide is_Named_thread() (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1544/head:pull/1544
$ git checkout pull/1544

Update a local copy of the PR:
$ git checkout pull/1544
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1544/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1544

View PR using the GUI difftool:
$ git pr show -t 1544

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1544.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 5, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 02c9bf087e50885bbc8028415c4e674947ee7a16 8268852: AsyncLogWriter should not overide is_Named_thread() Jul 5, 2023
@openjdk
Copy link

openjdk bot commented Jul 5, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 5, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268852: AsyncLogWriter should not overide is_Named_thread()

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 688a823: 8307299: Move more DnD tests to open
  • 93bfec2: 8307083: Open source some drag and drop tests 3
  • b3cf45a: 8306812: Open source several AWT Miscellaneous tests
  • e8e87c4: 8289547: Update javax/swing/Popup/TaskbarPositionTest.java
  • b8cf161: 8307078: Opensource and clean up five more AWT Focus related tests
  • 8d49a8a: 8306638: Open source some AWT tests related to datatransfer and Toolkit

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 5, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 5, 2023

Webrevs

@shipilev
Copy link
Member Author

shipilev commented Jul 6, 2023

Testing is clean. Push approval is here.

/integrate

@openjdk
Copy link

openjdk bot commented Jul 6, 2023

Going to push as commit 8a9162f.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 688a823: 8307299: Move more DnD tests to open
  • 93bfec2: 8307083: Open source some drag and drop tests 3
  • b3cf45a: 8306812: Open source several AWT Miscellaneous tests
  • e8e87c4: 8289547: Update javax/swing/Popup/TaskbarPositionTest.java
  • b8cf161: 8307078: Opensource and clean up five more AWT Focus related tests
  • 8d49a8a: 8306638: Open source some AWT tests related to datatransfer and Toolkit

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 6, 2023
@openjdk openjdk bot closed this Jul 6, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 6, 2023
@openjdk
Copy link

openjdk bot commented Jul 6, 2023

@shipilev Pushed as commit 8a9162f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8268852-async-named-thread branch July 20, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant