Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8285980: Several tests in compiler/c2/irTests miss @requires vm.compiler2.enabled #1548

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jul 5, 2023

I backport this for parity with 17.0.9-oracle.

These files omitted:
test/hotspot/jtreg/compiler/c2/irTests/TestCountedLoopSafepoint.java Added in 8281322 in 19.
test/hotspot/jtreg/compiler/c2/irTests/TestDuplicateBackedge.java Added in 8279888 in 19.
test/hotspot/jtreg/compiler/c2/irTests/TestIRAddIdealNotXPlusC.java Added in 8279607 in 19
test/hotspot/jtreg/compiler/c2/irTests/TestIRLShiftIdeal_XPlusX_LShiftC.java Added in 8278114 in 19.
test/hotspot/jtreg/compiler/c2/irTests/TestLongRangeChecks.java Added in 8259609 in 18

test/hotspot/jtreg/compiler/c2/irTests/TestSuperwordFailsUnrolling.java
Trivial resolve


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1548/head:pull/1548
$ git checkout pull/1548

Update a local copy of the PR:
$ git checkout pull/1548
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1548/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1548

View PR using the GUI difftool:
$ git pr show -t 1548

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1548.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 5, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1f9f8738f344ecbc0270608ee84eb92138f349a2 8285980: Several tests in compiler/c2/irTests miss @requires vm.compiler2.enabled Jul 5, 2023
@openjdk
Copy link

openjdk bot commented Jul 5, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jul 5, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 5, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 5, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8285980: Several tests in compiler/c2/irTests miss @requires vm.compiler2.enabled

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 688a823: 8307299: Move more DnD tests to open
  • 93bfec2: 8307083: Open source some drag and drop tests 3
  • b3cf45a: 8306812: Open source several AWT Miscellaneous tests

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 5, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Jul 10, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jul 10, 2023

Going to push as commit 5fd04f9.
Since your change was applied there have been 18 commits pushed to the master branch:

  • efd7f7f: 8306137: Open source several AWT ScrollPane related tests
  • 592d64b: 8310549: avoid potential leaks in KeystoreImpl.m related to JNU_CHECK_EXCEPTION early returns
  • 7a4708b: 8301700: Increase the default TLS Diffie-Hellman group size from 1024-bit to 2048-bit
  • 966fc82: 8276799: Implementation of JEP 422: Linux/RISC-V Port
  • f02d019: 8306765: Some client related jtreg problem list entries are malformed
  • c39f3c1: 8278141: LIR_OpLoadKlass::_info shadows the field of the same name from LIR_Op
  • a34d90b: 8277860: PPC: Remove duplicate info != NULL check
  • d7a59f3: 8277417: C1 LIR instruction for load-klass
  • c2e274e: 8304725: AsyncGetCallTrace can cause SIGBUS on M1
  • 3b4df97: 6176679: Application freezes when copying an animated gif image to the system clipboard
  • ... and 8 more: https://git.openjdk.org/jdk17u-dev/compare/e8e87c47d8f1d35b83e8bae867a7426866108731...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 10, 2023
@openjdk openjdk bot closed this Jul 10, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 10, 2023
@openjdk
Copy link

openjdk bot commented Jul 10, 2023

@GoeLin Pushed as commit 5fd04f9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8285980 branch July 10, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants