Skip to content

8305421: Work around JDK-8305420 in CDSJDITest.java #1552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

luchenlin
Copy link

@luchenlin luchenlin commented Jul 6, 2023

I backport this for parity with 17.0.9-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8305421: Work around JDK-8305420 in CDSJDITest.java (Sub-task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1552/head:pull/1552
$ git checkout pull/1552

Update a local copy of the PR:
$ git checkout pull/1552
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1552/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1552

View PR using the GUI difftool:
$ git pr show -t 1552

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1552.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 6, 2023

👋 Welcome back luchenlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9ce5fdc96262ac80c5a2ac2d51a149408d3d727a 8305421: Work around JDK-8305420 in CDSJDITest.java Jul 6, 2023
@openjdk
Copy link

openjdk bot commented Jul 6, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 6, 2023

@luchenlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8305421: Work around JDK-8305420 in CDSJDITest.java

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 6, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 6, 2023

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Jul 10, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jul 10, 2023

@GoeLin Only the author (@luchenlin) is allowed to issue the integrate command.

@GoeLin
Copy link
Member

GoeLin commented Jul 10, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 10, 2023

@GoeLin The change author (@luchenlin) must issue an integrate command before the integration can be sponsored.

@luchenlin
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 11, 2023
@openjdk
Copy link

openjdk bot commented Jul 11, 2023

@luchenlin
Your change (at version a82e1f5) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Jul 11, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 11, 2023

Going to push as commit f956352.
Since your change was applied there have been 21 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 11, 2023
@openjdk openjdk bot closed this Jul 11, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 11, 2023
@openjdk
Copy link

openjdk bot commented Jul 11, 2023

@GoeLin @luchenlin Pushed as commit f956352.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants