Skip to content

8306076: Open source AWT misc tests #1558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kspeeyu
Copy link
Contributor

@kspeeyu kspeeyu commented Jul 7, 2023

Backport for JDK-8306076
Open source AWT misc tests
Clean test-only backport
New tests all pass
tier1 tested with GHA
tier2 tested on linux


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1558/head:pull/1558
$ git checkout pull/1558

Update a local copy of the PR:
$ git checkout pull/1558
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1558/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1558

View PR using the GUI difftool:
$ git pr show -t 1558

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1558.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 7, 2023

👋 Welcome back kspeeyu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 7, 2023

⚠️ @kspeeyu could not find any commit with hash 8b953859ccecb4e36afef1c30cc36d527efa3d1c. Please update the title with the hash for an existing commit.

@kspeeyu kspeeyu changed the title Backport 8b953859ccecb4e36afef1c30cc36d527efa3d1c Backport f7d45b85a5c664a87c94e0baccd8b9eddce27e2c Jul 7, 2023
@openjdk openjdk bot changed the title Backport f7d45b85a5c664a87c94e0baccd8b9eddce27e2c 8306076: Open source AWT misc tests Jul 7, 2023
@openjdk
Copy link

openjdk bot commented Jul 7, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 7, 2023

@kspeeyu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306076: Open source AWT misc tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • cb35d88: 8299158: Improve MD5 intrinsic on AArch64
  • ed698e6: 8306718: Optimize and opensource some old AWT tests
  • 5fd04f9: 8285980: Several tests in compiler/c2/irTests miss @requires vm.compiler2.enabled
  • efd7f7f: 8306137: Open source several AWT ScrollPane related tests
  • 592d64b: 8310549: avoid potential leaks in KeystoreImpl.m related to JNU_CHECK_EXCEPTION early returns
  • 7a4708b: 8301700: Increase the default TLS Diffie-Hellman group size from 1024-bit to 2048-bit
  • 966fc82: 8276799: Implementation of JEP 422: Linux/RISC-V Port
  • f02d019: 8306765: Some client related jtreg problem list entries are malformed
  • c39f3c1: 8278141: LIR_OpLoadKlass::_info shadows the field of the same name from LIR_Op
  • a34d90b: 8277860: PPC: Remove duplicate info != NULL check
  • ... and 5 more: https://git.openjdk.org/jdk17u-dev/compare/fc08b730142dcde39291be8044dfa667b98363ad...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 7, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 7, 2023

Webrevs

@phohensee
Copy link
Member

Tagged the JBS issue.

@kspeeyu
Copy link
Contributor Author

kspeeyu commented Jul 10, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 10, 2023
@openjdk
Copy link

openjdk bot commented Jul 10, 2023

@kspeeyu
Your change (at version a668eb0) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 10, 2023

Going to push as commit afffb37.
Since your change was applied there have been 16 commits pushed to the master branch:

  • b42886f: 8306636: Disable compiler/c2/Test6905845.java with -XX:TieredStopAtLevel=3
  • cb35d88: 8299158: Improve MD5 intrinsic on AArch64
  • ed698e6: 8306718: Optimize and opensource some old AWT tests
  • 5fd04f9: 8285980: Several tests in compiler/c2/irTests miss @requires vm.compiler2.enabled
  • efd7f7f: 8306137: Open source several AWT ScrollPane related tests
  • 592d64b: 8310549: avoid potential leaks in KeystoreImpl.m related to JNU_CHECK_EXCEPTION early returns
  • 7a4708b: 8301700: Increase the default TLS Diffie-Hellman group size from 1024-bit to 2048-bit
  • 966fc82: 8276799: Implementation of JEP 422: Linux/RISC-V Port
  • f02d019: 8306765: Some client related jtreg problem list entries are malformed
  • c39f3c1: 8278141: LIR_OpLoadKlass::_info shadows the field of the same name from LIR_Op
  • ... and 6 more: https://git.openjdk.org/jdk17u-dev/compare/fc08b730142dcde39291be8044dfa667b98363ad...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 10, 2023
@openjdk openjdk bot closed this Jul 10, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 10, 2023
@openjdk
Copy link

openjdk bot commented Jul 10, 2023

@phohensee @kspeeyu Pushed as commit afffb37.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants