-
Notifications
You must be signed in to change notification settings - Fork 224
8303154: Investigate and improve instruction cache flushing during compilation #1559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
just a note, almost not related to this PR: gha scipts in 17u-dev can't cross-compile for risc-v yet |
Hi @VladimirKempik @GoeLin, I just submit a backport PR to enable GHA cross-compiling for linux-riscv64 at #1562. Not sure if we should bump the GHA runner to 22.04 too as JDK-8293107 did? |
/integrate |
Going to push as commit 1248b15.
Your commit was automatically rebased without conflicts. |
Well, this PR is not the best place to discuss this. |
I backport this for parity with 17.0.9-oracle.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1559/head:pull/1559
$ git checkout pull/1559
Update a local copy of the PR:
$ git checkout pull/1559
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1559/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1559
View PR using the GUI difftool:
$ git pr show -t 1559
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1559.diff
Webrev
Link to Webrev Comment