Skip to content

8303154: Investigate and improve instruction cache flushing during compilation #1559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jul 10, 2023

I backport this for parity with 17.0.9-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8303154: Investigate and improve instruction cache flushing during compilation (Enhancement - P2)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1559/head:pull/1559
$ git checkout pull/1559

Update a local copy of the PR:
$ git checkout pull/1559
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1559/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1559

View PR using the GUI difftool:
$ git pr show -t 1559

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1559.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 10, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b7945bc9e5db5761f17a9e56246424fbcab21627 8303154: Investigate and improve instruction cache flushing during compilation Jul 10, 2023
@openjdk
Copy link

openjdk bot commented Jul 10, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 10, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303154: Investigate and improve instruction cache flushing during compilation

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 10, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 10, 2023

Webrevs

@VladimirKempik
Copy link

just a note, almost not related to this PR: gha scipts in 17u-dev can't cross-compile for risc-v yet

@feilongjiang
Copy link
Member

just a note, almost not related to this PR: gha scipts in 17u-dev can't cross-compile for risc-v yet

Hi @VladimirKempik @GoeLin, I just submit a backport PR to enable GHA cross-compiling for linux-riscv64 at #1562. Not sure if we should bump the GHA runner to 22.04 too as JDK-8293107 did?

@GoeLin
Copy link
Member Author

GoeLin commented Jul 12, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jul 12, 2023

Going to push as commit 1248b15.
Since your change was applied there have been 13 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 12, 2023
@openjdk openjdk bot closed this Jul 12, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 12, 2023
@openjdk
Copy link

openjdk bot commented Jul 12, 2023

@GoeLin Pushed as commit 1248b15.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin
Copy link
Member Author

GoeLin commented Jul 12, 2023

just a note, almost not related to this PR: gha scipts in 17u-dev can't cross-compile for risc-v yet

Hi @VladimirKempik @GoeLin, I just submit a backport PR to enable GHA cross-compiling for linux-riscv64 at #1562. Not sure if we should bump the GHA runner to 22.04 too as JDK-8293107 did?

Well, this PR is not the best place to discuss this.
Updating Ubuntu means that jdk17u is no more checked against old environments. As installations often stay on old OSes, this might introduce unwanted problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants