Skip to content

8180266: Convert sun/security/provider/KeyStore/DKSTest.sh to Java Jtreg Test #1560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jul 10, 2023

I backport this for parity with 17.0.9-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8180266: Convert sun/security/provider/KeyStore/DKSTest.sh to Java Jtreg Test (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1560/head:pull/1560
$ git checkout pull/1560

Update a local copy of the PR:
$ git checkout pull/1560
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1560/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1560

View PR using the GUI difftool:
$ git pr show -t 1560

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1560.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 10, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7f313b0cef7d0e9732beed6c61298815306531e0 8180266: Convert sun/security/provider/KeyStore/DKSTest.sh to Java Jtreg Test Jul 10, 2023
@openjdk
Copy link

openjdk bot commented Jul 10, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 10, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8180266: Convert sun/security/provider/KeyStore/DKSTest.sh to Java Jtreg Test

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 5fd04f9: 8285980: Several tests in compiler/c2/irTests miss @requires vm.compiler2.enabled

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 10, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 10, 2023

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Jul 12, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jul 12, 2023

Going to push as commit 4eeb1c9.
Since your change was applied there have been 10 commits pushed to the master branch:

  • f45578e: 8225012: sanity/client/SwingSet/src/ToolTipDemoTest.java fails on Windows
  • a299757: 8297476: Increase InlineSmallCode default from 1000 to 2500 for RISC-V
  • d5eec58: 8283929: GHA: Add RISC-V build config
  • f956352: 8305421: Work around JDK-8305420 in CDSJDITest.java
  • c9194e7: 8306566: Open source several clipboard AWT tests
  • afffb37: 8306076: Open source AWT misc tests
  • b42886f: 8306636: Disable compiler/c2/Test6905845.java with -XX:TieredStopAtLevel=3
  • cb35d88: 8299158: Improve MD5 intrinsic on AArch64
  • ed698e6: 8306718: Optimize and opensource some old AWT tests
  • 5fd04f9: 8285980: Several tests in compiler/c2/irTests miss @requires vm.compiler2.enabled

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 12, 2023
@openjdk openjdk bot closed this Jul 12, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 12, 2023
@openjdk
Copy link

openjdk bot commented Jul 12, 2023

@GoeLin Pushed as commit 4eeb1c9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant