Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8271199: Mutual TLS handshake fails signing client certificate with custom sensitive PKCS11 key #157

Closed
wants to merge 1 commit into from

Conversation

alexeybakhtin
Copy link

@alexeybakhtin alexeybakhtin commented Feb 11, 2022

This is a clean backport of JDK-8271199 to JDK17u-dev


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8271199: Mutual TLS handshake fails signing client certificate with custom sensitive PKCS11 key

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/157/head:pull/157
$ git checkout pull/157

Update a local copy of the PR:
$ git checkout pull/157
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/157/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 157

View PR using the GUI difftool:
$ git pr show -t 157

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/157.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 11, 2022

👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f6232982b91cb2314e96ddbde3984836a810a556 8271199: Mutual TLS handshake fails signing client certificate with custom sensitive PKCS11 key Feb 11, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Feb 11, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 11, 2022

@alexeybakhtin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271199: Mutual TLS handshake fails signing client certificate with custom sensitive PKCS11 key

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 2965051: 8277299: STACK_OVERFLOW in Java_sun_awt_shell_Win32ShellFolder2_getIconBits

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready rfr labels Feb 11, 2022
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 11, 2022

Webrevs

@alexeybakhtin
Copy link
Author

@alexeybakhtin alexeybakhtin commented Feb 14, 2022

/integrate

@openjdk openjdk bot added the sponsor label Feb 14, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Feb 14, 2022

@alexeybakhtin
Your change (at version 937e4e7) is now ready to be sponsored by a Committer.

@yan-too
Copy link

@yan-too yan-too commented Feb 14, 2022

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Feb 14, 2022

Going to push as commit 87010e7.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 2965051: 8277299: STACK_OVERFLOW in Java_sun_awt_shell_Win32ShellFolder2_getIconBits

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Feb 14, 2022
@openjdk openjdk bot closed this Feb 14, 2022
@openjdk openjdk bot removed ready rfr sponsor labels Feb 14, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Feb 14, 2022

@yan-too @alexeybakhtin Pushed as commit 87010e7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
2 participants