-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8310259: Pin msys2/setup-msys2 github action to a specific commit #1573
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
/issue add 8309934, 8310183 |
This backport pull request has now been updated with issue from the original commit. |
@GoeLin Adding additional issue to issue list: |
Webrevs
|
We probably need jtreg 7 to build with 17.
/issue remove 8309934, 8310183 |
I removed setting the Java version to 17. |
@GoeLin Removing additional issue from issue list: |
GHA tests had passed before I removed the copyright change. |
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 2b8c260.
Your commit was automatically rebased without conflicts. |
I backport this to work around an error of msys2
I ran into this testing the bump to jtreg 7.2.
This subsumes previous changes 8309934 and 8310183.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1573/head:pull/1573
$ git checkout pull/1573
Update a local copy of the PR:
$ git checkout pull/1573
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1573/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1573
View PR using the GUI difftool:
$ git pr show -t 1573
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1573.diff
Webrev
Link to Webrev Comment