Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8308283: Build failure with GCC12 & GCC13 #1576

Closed
wants to merge 1 commit into from

Conversation

benty-amzn
Copy link

@benty-amzn benty-amzn commented Jul 12, 2023

Backport is not clean because https://bugs.openjdk.org/browse/JDK-8294466 was never backported.

Required to build with GCC 13.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8308283: Build failure with GCC12 & GCC13 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1576/head:pull/1576
$ git checkout pull/1576

Update a local copy of the PR:
$ git checkout pull/1576
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1576/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1576

View PR using the GUI difftool:
$ git pr show -t 1576

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1576.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 12, 2023

👋 Welcome back btaylor! A progress list of the required criteria for merging this PR into pr/1575 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport bfc3ccd90d579f6cba3a704766b7a1ea56beebe1 8308283: Build failure with GCC12 & GCC13 Jul 12, 2023
@openjdk
Copy link

openjdk bot commented Jul 12, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jul 12, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 12, 2023

Webrevs

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/1575 to master July 15, 2023 16:08
@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout 8308283
git fetch https://git.openjdk.org/jdk17u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk
Copy link

openjdk bot commented Jul 15, 2023

@benty-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308283: Build failure with GCC12 & GCC13

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 0dd98fd: 8275303: sun/java2d/pipe/InterpolationQualityTest.java fails with D3D basic render driver
  • f18ecea: 8297923: java.awt.ScrollPane broken after multiple scroll up/down
  • d79c2ef: 8311862: RISC-V: small improvements to shift immediate instructions

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 15, 2023
@benty-amzn benty-amzn closed this Jul 17, 2023
@benty-amzn benty-amzn force-pushed the 8308283 branch 2 times, most recently from a96f510 to 6d4bfb7 Compare July 17, 2023 16:53
@benty-amzn benty-amzn reopened this Jul 17, 2023
@openjdk
Copy link

openjdk bot commented Jul 17, 2023

@benty-amzn Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@phohensee
Copy link
Member

Pre-submit test failure looks like an infra issue.

@benty-amzn
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 18, 2023
@openjdk
Copy link

openjdk bot commented Jul 18, 2023

@benty-amzn
Your change (at version 1a469d0) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 18, 2023

Going to push as commit e3dad43.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 0dd98fd: 8275303: sun/java2d/pipe/InterpolationQualityTest.java fails with D3D basic render driver
  • f18ecea: 8297923: java.awt.ScrollPane broken after multiple scroll up/down
  • d79c2ef: 8311862: RISC-V: small improvements to shift immediate instructions

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 18, 2023
@openjdk openjdk bot closed this Jul 18, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 18, 2023
@openjdk
Copy link

openjdk bot commented Jul 18, 2023

@phohensee @benty-amzn Pushed as commit e3dad43.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@benty-amzn benty-amzn deleted the 8308283 branch July 18, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants