Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8279385: [test] Adjust sun/security/pkcs12/KeytoolOpensslInteropTest.java after 8278344 #158

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Feb 11, 2022


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8279385: [test] Adjust sun/security/pkcs12/KeytoolOpensslInteropTest.java after 8278344

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/158/head:pull/158
$ git checkout pull/158

Update a local copy of the PR:
$ git checkout pull/158
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/158/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 158

View PR using the GUI difftool:
$ git pr show -t 158

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/158.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 11, 2022

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 01f93ddf18daea5c0798ac949c6717c37d9cefa0 8279385: [test] Adjust sun/security/pkcs12/KeytoolOpensslInteropTest.java after 8278344 Feb 11, 2022
@openjdk
Copy link

openjdk bot commented Feb 11, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 11, 2022

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279385: [test]  Adjust sun/security/pkcs12/KeytoolOpensslInteropTest.java after 8278344

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 11, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 11, 2022

Webrevs

@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 15, 2022

Going to push as commit a7010a2.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 7833c7d: 8280373: Update Xalan serializer / SystemIDResolver to align with JDK-8270492
  • 8207e69: 8272541: Incorrect overflow test in Toom-Cook branch of BigInteger multiplication
  • ec1733d: 8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10
  • 6cee018: 8272600: (test) Use native "sleep" in Basic.java
  • 87010e7: 8271199: Mutual TLS handshake fails signing client certificate with custom sensitive PKCS11 key
  • 2965051: 8277299: STACK_OVERFLOW in Java_sun_awt_shell_Win32ShellFolder2_getIconBits

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 15, 2022
@openjdk openjdk bot closed this Feb 15, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 15, 2022
@openjdk
Copy link

openjdk bot commented Feb 15, 2022

@MBaesken Pushed as commit a7010a2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant