Skip to content

8306060: Open source few AWT Insets related tests#1581

Closed
kspeeyu wants to merge 1 commit intoopenjdk:masterfrom
kspeeyu:JDK-8306060
Closed

8306060: Open source few AWT Insets related tests#1581
kspeeyu wants to merge 1 commit intoopenjdk:masterfrom
kspeeyu:JDK-8306060

Conversation

@kspeeyu
Copy link
Contributor

@kspeeyu kspeeyu commented Jul 13, 2023

Backport for JDK-8306060
Open source few AWT Insets related tests
New tests all pass
tier1 tested with GHA
tier2 tested on linux


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8306060: Open source few AWT Insets related tests (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1581/head:pull/1581
$ git checkout pull/1581

Update a local copy of the PR:
$ git checkout pull/1581
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1581/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1581

View PR using the GUI difftool:
$ git pr show -t 1581

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1581.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 13, 2023

👋 Welcome back kspeeyu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9a68d1d952c308c03c29747794d409831008c144 8306060: Open source few AWT Insets related tests Jul 13, 2023
@openjdk
Copy link

openjdk bot commented Jul 13, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jul 13, 2023
@openjdk
Copy link

openjdk bot commented Jul 13, 2023

@kspeeyu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306060: Open source few AWT Insets related tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 13, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 13, 2023

Webrevs

@kspeeyu
Copy link
Contributor Author

kspeeyu commented Jul 13, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 13, 2023
@openjdk
Copy link

openjdk bot commented Jul 13, 2023

@kspeeyu
Your change (at version 5f565a7) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Jul 14, 2023

@kspeeyu, next time please wait with integrating until the jdk*-fix-yes label is on the JBS bug!

@shipilev
Copy link
Member

Push approval is here.

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 14, 2023

Going to push as commit 148af11.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 97cf4fe: 8309266: C2: assert(final_con == (jlong)final_int) failed: final value should be integer
  • a6ef655: 8309119: [17u/11u] Redo JDK-8297951: C2: Create skeleton predicates for all If nodes in loop predication
  • 3cc7858: 8307683: Loop Predication should not hoist range checks with trap on success projection by negating their condition

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 14, 2023
@openjdk openjdk bot closed this Jul 14, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 14, 2023
@openjdk
Copy link

openjdk bot commented Jul 14, 2023

@shipilev @kspeeyu Pushed as commit 148af11.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kspeeyu
Copy link
Contributor Author

kspeeyu commented Jul 14, 2023

@kspeeyu, next time please wait with integrating until the jdk*-fix-yes label is on the JBS bug!

sure, will do. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants